Add types for react-native-markdown-view

[fabio-nettis]

Add type definitions for the react-native-markdown-view package. Maintainer seems to have abandoned the repository and the type definitions used in the package are not exported anywhere in it. I basically just copied the type definitions from here and modified them a bit.

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

If adding a new definition:

• The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration

[typescript-bot]

@fabio-nettis Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• react-native-markdown-view (new!) — on npm, on unpkg
  • 1 added owner: ✎@fabio-nettis

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ❌ Continuous integration tests have failed
• 🕐 Only a DT maintainer can approve changes when there are new packages added

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 31 days — it is considered abandoned, and therefore closed!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 61734,
  "author": "fabio-nettis",
  "headCommitOid": "ad3359649ef5515a31f9105e3e1cff873f35860e",
  "mergeBaseOid": "46eb6db86dd5dc57737e3cb07ff71dbf8fed0d51",
  "lastPushDate": "2022-08-15T10:22:33.000Z",
  "lastActivityDate": "2022-08-15T10:30:18.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "react-native-markdown-view",
      "kind": "add",
      "files": [
        {
          "path": "types/react-native-markdown-view/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-native-markdown-view/react-native-markdown-view-tests.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-native-markdown-view/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/react-native-markdown-view/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "fabio-nettis"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1214782049,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/ad3359649ef5515a31f9105e3e1cff873f35860e/checks?check_suite_id=7815118552"
}

[typescript-bot]

🔔 @fabio-nettis — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

[typescript-bot]

@fabio-nettis The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

@fabio-nettis The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

@fabio-nettis The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[fabio-nettis]

Maintainer action needed

Checked the CI errors and it doesn't seem to be an issue with my definition but the errors origin form the react-native package. Here an error snippet:

Error: ../react-native/globals.d.ts(77,15): error TS2300: Duplicate identifier 'FormData'.
Error: ../react-native/globals.d.ts(101,13): error TS2403: Subsequent variable declarations must have the same type.  Variable 'Headers' must be of type '{ new (init?: HeadersInit | undefined): Headers; prototype: Headers; }', but here has type '{ new (init?: HeadersInit_ | undefined): Headers; prototype: Headers; }'.
Error: ../react-native/globals.d.ts(135,5): error TS2717: Subsequent property declarations must have the same type.  Property 'body' must be of type 'BodyInit | null | undefined', but here has type 'BodyInit_ | undefined'.
Error: ../react-native/globals.d.ts(137,5): error TS2717: Subsequent property declarations must have the same type.  Property 'headers' must be of type 'HeadersInit | undefined', but here has type 'HeadersInit_ | undefined'.
...

[typescript-bot]

@fabio-nettis I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Sep 14th (in a week) if the issues aren't addressed.

[typescript-bot]

@fabio-nettis To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you!