Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to proper NightwatchOptions #62027

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benjaminr-ps
Copy link
Contributor

...as NightwatchTestSettingGeneric is more incomplete.

Still NightwatchOptions lacks some properties and requires better typing

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: API
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

...as NightwatchTestSettingGeneric is more incomplete.

Still NightwatchOptions lacks some properties and requires better typing
@typescript-bot typescript-bot added this to Needs Author Action in New Pull Request Status Board Aug 30, 2022
@DangerBotOSS
Copy link

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

nightwatch (unpkg)

was missing the following properties:

  1. createClient
  2. client
  3. cli
  4. runTests
  5. CliRunner
as well as these 2 other properties...

initClient, runner

Generated by 🚫 dangerJS against ffbb194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants