ember-qunit: export SetupTestOptions

[chriskrycho]

This unblocks ember-cli/ember-cli#9972.

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/emberjs/ember-qunit/blob/master/addon-test-support/index.js#L29 &c. – this is an internal API we want to have available. Problem will go away once Convert to TS or supply ambient definitions emberjs/ember-qunit#957 is done.

[typescript-bot]

@chriskrycho Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• ember-qunit — on npm, on unpkg (author is owner)
  • owner-approval: @dfreeman

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 62073,
  "author": "chriskrycho",
  "headCommitOid": "058727f09bda6730356ec9e76a17c5fc8e08819a",
  "mergeBaseOid": "7143245b02a8118d9cfc1467da638433c5beb6c6",
  "lastPushDate": "2022-09-01T18:06:17.000Z",
  "lastActivityDate": "2022-09-01T19:08:25.000Z",
  "mergeOfferDate": "2022-09-01T18:18:24.000Z",
  "mergeRequestDate": "2022-09-01T19:08:25.000Z",
  "mergeRequestUser": "chriskrycho",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "ember-qunit",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember-qunit/ember-qunit-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/ember-qunit/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "dfreeman",
        "chriskrycho",
        "jamescdavis"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "dfreeman",
      "date": "2022-09-01T18:17:41.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1234315443,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @dfreeman @jamescdavis — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[DangerBotOSS]

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

ember-qunit (unpkg)

was missing the following properties:

1. name
2. init
3. included
4. targetOptions
5. treeForVendor

as well as these 2 other properties...

treeForAddonTestSupport, setTestGenerator

Generated by 🚫 dangerJS against 058727f

[chriskrycho]

These were unused, and just happened to get caught in this change. :sigh: Removing.

[typescript-bot]

@dfreeman Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[typescript-bot]

@chriskrycho: Everything looks good here. I am ready to merge this PR (at 058727f) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@dfreeman, @jamescdavis: you can do this too.)

[chriskrycho]

Ready to merge