Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo ture -> true, on uglify-js #62824

Merged

Conversation

Smankusors
Copy link
Contributor

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

--

well, it's just a very small PR. Let me know what do you think 😉

@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 21, 2022

@Smankusors Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 62824,
  "author": "Smankusors",
  "headCommitOid": "5ecc838775ab881e83dbd108582d243766b3627e",
  "mergeBaseOid": "9afdd47a5f36be9eb2f3ccf2d19221ca5c6cabff",
  "lastPushDate": "2022-10-21T17:08:48.000Z",
  "lastActivityDate": "2022-10-21T19:45:51.000Z",
  "mergeOfferDate": "2022-10-21T19:45:37.000Z",
  "mergeRequestDate": "2022-10-21T19:45:51.000Z",
  "mergeRequestUser": "peterblazejewicz",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "uglify-js",
      "kind": "edit",
      "files": [
        {
          "path": "types/uglify-js/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "alan-agius4",
        "tkrotoff",
        "johnnyreilly",
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2022-10-21T19:44:52.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1287232193,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Untested Change This PR does not touch tests labels Oct 21, 2022
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Oct 21, 2022
@typescript-bot
Copy link
Contributor

Hey @Smankusors,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Contributor

🔔 @alan-agius4 @tkrotoff @johnnyreilly @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@DangerBotOSS
Copy link

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

uglify-js (unpkg)

was missing the following properties:

  1. FILES
  2. default_options

Generated by 🚫 dangerJS against 5ecc838

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Oct 21, 2022
Copy link
Member

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@Smankusors thanks!

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Oct 21, 2022
@typescript-bot
Copy link
Contributor

@Smankusors: Everything looks good here. I am ready to merge this PR (at 5ecc838) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@alan-agius4, @tkrotoff, @johnnyreilly, @peterblazejewicz: you can do this too.)

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board Oct 21, 2022
@peterblazejewicz
Copy link
Member

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Oct 21, 2022
@typescript-bot typescript-bot merged commit 2426529 into DefinitelyTyped:master Oct 21, 2022
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants