Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotwired__turbo-rails] Create types for @hotwired/turbo-rails #62834

Closed
wants to merge 1 commit into from

Conversation

kzkn
Copy link

@kzkn kzkn commented Oct 22, 2022

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 22, 2022

@kzkn Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes when there are new packages added

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 62834,
  "author": "kzkn",
  "headCommitOid": "592ddf8f5a352839c76f83f964fefe5a4f502b51",
  "mergeBaseOid": "08cc5121cb7a874a205792976affef0397e3de1b",
  "lastPushDate": "2022-10-25T03:44:37.000Z",
  "lastActivityDate": "2022-10-25T03:44:37.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "hotwired__turbo-rails",
      "kind": "add",
      "files": [
        {
          "path": "types/hotwired__turbo-rails/cable.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/hotwired__turbo-rails/hotwired__turbo-rails-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/hotwired__turbo-rails/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/hotwired__turbo-rails/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/hotwired__turbo-rails/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/hotwired__turbo-rails/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "kzkn"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1287618238,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the New Definition This PR creates a new definition package. label Oct 22, 2022
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Oct 22, 2022
@typescript-bot
Copy link
Contributor

🔔 @kzkn — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Oct 22, 2022
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Oct 22, 2022
@typescript-bot
Copy link
Contributor

@kzkn The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Oct 22, 2022
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Oct 22, 2022
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Oct 22, 2022
@typescript-bot
Copy link
Contributor

@kzkn The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Oct 22, 2022
@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Oct 25, 2022
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Oct 25, 2022
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Oct 25, 2022
@kzkn
Copy link
Author

kzkn commented Oct 25, 2022

I have confirmed all checks have passed 😄
I will consult with the community to see if this type definition should be made public. I will close it once.
hotwired/turbo-rails#18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Definition This PR creates a new definition package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants