[express-serve-static-core] missiong type of router.stack: Layer[] (#63290)

[DerHerrGammler]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: <>

Layer core code: https://github.com/expressjs/express/blob/master/lib/router/layer.js
Route core code: https://github.com/expressjs/express/blob/master/lib/router/route.js
a additional manipulation of those tyoes happens in other files

[typescript-bot]

@DerHerrGammler Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• express-serve-static-core — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ❌ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 64 days — it is considered abandoned, and therefore closed!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 63329,
  "author": "DerHerrGammler",
  "headCommitOid": "146a527e1fc477821f3844493e459fb8434fd4c1",
  "mergeBaseOid": "30d9a69b09462171fc5bc63b3f20a2e0e40e28af",
  "lastPushDate": "2022-11-20T01:20:00.000Z",
  "lastActivityDate": "2022-12-11T22:13:31.000Z",
  "hasMergeConflict": true,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "express-serve-static-core",
      "kind": "edit",
      "files": [
        {
          "path": "types/express-serve-static-core/express-serve-static-core-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/express-serve-static-core/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "borisyankov",
        "micksatana",
        "samijaber",
        "JoseLion",
        "dwrss",
        "andoshin11"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "navya9singh",
      "date": "2022-12-09T23:27:45.000Z"
    }
  ],
  "mainBotCommentID": 1321007986,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @borisyankov @micksatana @samijaber @JoseLion @dwrss @andoshin11 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

Re-ping @borisyankov, @micksatana, @samijaber, @JoseLion, @dwrss, @andoshin11:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[typescript-bot]

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @DerHerrGammler.

(Ping @borisyankov, @micksatana, @samijaber, @JoseLion, @dwrss, @andoshin11.)

[navya9singh]

How is Route different from IRoute?

[DerHerrGammler]

In IRoute it semes that there always exists the definitions of the funtion but in the Route interface are no definitions of any methodes. And instead there is a methods object that defines with http methodes for this route are defined.

[DerHerrGammler]

If its better for you that the methodes object is in the IRoute interface i could propably change that but i dont think that this is accurat to the structure of the Layers in the Stack

[typescript-bot]

@DerHerrGammler One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

[typescript-bot]

@DerHerrGammler Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

[typescript-bot]

@DerHerrGammler To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you!