-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodemailer-html-to-text - remove deprecated option #63500
nodemailer-html-to-text - remove deprecated option #63500
Conversation
Fix the test code by moving the specification of the option from general options to selector option. Signed-off-by: Chris. Webster <chris@webstech.net>
@webstech Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 63500,
"author": "webstech",
"headCommitOid": "cf40b5a62f769701ccf243ad6a869ccce13fe385",
"mergeBaseOid": "58d2c92f9effecd46899a1ec01c24431af266cc5",
"lastPushDate": "2022-12-06T07:57:45.000Z",
"lastActivityDate": "2022-12-06T17:07:51.000Z",
"mergeOfferDate": "2022-12-06T15:49:55.000Z",
"mergeRequestDate": "2022-12-06T17:07:51.000Z",
"mergeRequestUser": "webstech",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "nodemailer-html-to-text",
"kind": "edit",
"files": [
{
"path": "types/nodemailer-html-to-text/nodemailer-html-to-text-tests.ts",
"kind": "test"
}
],
"owners": [
"fagundes"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "fagundes",
"date": "2022-12-06T15:49:13.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1338938662,
"ciResult": "pass"
} |
🔔 @fagundes — please review this PR in the next few days. Be sure to explicitly select |
Ready to merge |
Thanks @fagundes! |
Fix the test code by moving the specification of the option from general options to selector option.
npm test <package to test>
.Select one of these and delete the others:
If changing an existing definition:
Updating the test code to remove the use of deprecated options that are removed in the latest version of
html-to-text
.