Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodemailer-html-to-text - remove deprecated option #63500

Merged
merged 1 commit into from
Dec 6, 2022
Merged

nodemailer-html-to-text - remove deprecated option #63500

merged 1 commit into from
Dec 6, 2022

Conversation

webstech
Copy link
Contributor

@webstech webstech commented Dec 6, 2022

Fix the test code by moving the specification of the option from general options to selector option.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>

Updating the test code to remove the use of deprecated options that are removed in the latest version of html-to-text.

Fix the test code by moving the specification of the option
from general options to selector option.

Signed-off-by: Chris. Webster <chris@webstech.net>
@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 6, 2022

@webstech Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 63500,
  "author": "webstech",
  "headCommitOid": "cf40b5a62f769701ccf243ad6a869ccce13fe385",
  "mergeBaseOid": "58d2c92f9effecd46899a1ec01c24431af266cc5",
  "lastPushDate": "2022-12-06T07:57:45.000Z",
  "lastActivityDate": "2022-12-06T17:07:51.000Z",
  "mergeOfferDate": "2022-12-06T15:49:55.000Z",
  "mergeRequestDate": "2022-12-06T17:07:51.000Z",
  "mergeRequestUser": "webstech",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "nodemailer-html-to-text",
      "kind": "edit",
      "files": [
        {
          "path": "types/nodemailer-html-to-text/nodemailer-html-to-text-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "fagundes"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "fagundes",
      "date": "2022-12-06T15:49:13.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1338938662,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added this to Waiting for Code Reviews in Old Pull Request Status Board Dec 6, 2022
@typescript-bot
Copy link
Contributor

🔔 @fagundes — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Dec 6, 2022
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in Old Pull Request Status Board Dec 6, 2022
@webstech
Copy link
Contributor Author

webstech commented Dec 6, 2022

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Old Pull Request Status Board Dec 6, 2022
@typescript-bot typescript-bot merged commit 5c44d61 into DefinitelyTyped:master Dec 6, 2022
@webstech
Copy link
Contributor Author

webstech commented Dec 6, 2022

Thanks @fagundes!

@webstech webstech deleted the html-to-text-fix branch December 6, 2022 17:08
@typescript-bot typescript-bot removed this from Recently Merged in Old Pull Request Status Board Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants