Remove videojs-hotkeys definitions, they're now in the library

[Coteh]

ctd1500/videojs-hotkeys@6baf206

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>. in this case, I ran npm run test-all since I'm removing the definitions. No errors.

Select one of these and delete the others:

If removing a declaration:

• If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
• Delete the package's directory.
• Add it to notNeededPackages.json.

[typescript-bot]

@Coteh Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

1 package in this PR (and infra files)

• videojs-hotkeys (probably deleted!) — on npm, on unpkg (author is owner)
• Infra files
  • notNeededPackages.json

Code Reviews

There aren't any other owners of this package, so a DT maintainer will review it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ A DT maintainer needs to approve changes which affect DT infrastructure (notNeededPackages.json)

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Inactive

This PR has been inactive for 10 days — please merge or say something if there's a problem, otherwise it will be closed!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 63785,
  "author": "Coteh",
  "headCommitOid": "3146cf0a0b3b6ccb42f925c2534b7654e407385a",
  "mergeBaseOid": "1dcd97e06e5b89b61500bf9907df4b0bc0f81ad6",
  "lastPushDate": "2023-01-03T00:58:47.000Z",
  "lastActivityDate": "2023-03-18T03:58:42.000Z",
  "mergeOfferDate": "2023-03-18T03:59:26.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "notNeededPackages.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "videojs-hotkeys",
      "kind": "delete",
      "files": [
        {
          "path": "types/videojs-hotkeys/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/videojs-hotkeys/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/videojs-hotkeys/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/videojs-hotkeys/videojs-hotkeys-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Coteh"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2023-01-03T21:24:11.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1369303911,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @Coteh — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

[jakebailey]

LGTM but I'll leave the merge timing up to you, if you're trying to get ctd1500/videojs-hotkeys#83 in and released beforehand.

[typescript-bot]

After a month, no one has requested merging the PR 😞. I'm going to assume that the change is not wanted after all, and will therefore close it.

[Coteh]

LGTM but I'll leave the merge timing up to you, if you're trying to get ctd1500/videojs-hotkeys#83 in and released beforehand.

Yes I'm waiting for that PR to go in first so that the type definitions are in sync with what's in here.

Is it possible to get this PR reopened?

[jakebailey]

Done.

[typescript-bot]

Re-ping @Coteh / @«anyone?»:

This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Mar 16th (in three weeks) if this doesn't happen.

(If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.)

[Coteh]

@jakebailey Sorry, is it possible that this PR could be reopened again? Also, is it possible that the bot auto-closing can be disabled? If not, then I'll decide what to do with the PR by the time it comments again. Thanks.

[jakebailey]

It cannot be disabled.

[typescript-bot]

Re-ping @Coteh / @«anyone?»:

This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Apr 17th (in three weeks) if this doesn't happen.

(If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.)

[jakebailey]

I'm going to convert this PR to a draft for now, given the upstream types are not getting accepted in short order and the bot wants to keep DT clean.