New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list options and fix status object #64482
Add list options and fix status object #64482
Conversation
@b0939261761 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 64482,
"author": "b0939261761",
"headCommitOid": "a83784a6325f77c149058b5a6f79ff51d7dba635",
"mergeBaseOid": "055ec5302dd094d1fc5fe24e02905a89e3a5b2a5",
"lastPushDate": "2023-02-25T09:20:05.000Z",
"lastActivityDate": "2023-03-18T06:47:05.000Z",
"mergeOfferDate": "2023-03-17T17:29:19.000Z",
"mergeRequestDate": "2023-03-18T06:47:05.000Z",
"mergeRequestUser": "martin-badin",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "imapflow",
"kind": "edit",
"files": [
{
"path": "types/imapflow/index.d.ts",
"kind": "definition"
}
],
"owners": [
"jeffreyratton98",
"martin-badin",
"grayson-code"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2023-03-17T17:28:33.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "martin-badin",
"date": "2023-03-15T12:59:10.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1445039610,
"ciResult": "pass"
} |
🔔 @jeffreyratton98 @martin-badin @Grayson-code — please review this PR in the next few days. Be sure to explicitly select |
@@ -293,7 +296,7 @@ export interface SearchObject { | |||
|
|||
export interface StatusObject { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can extend this interface from StatusQuery. The interface has the same properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export interface StatusObject {
path: string;
messages?: number;
recent?: number;
uid?: number;
uidValidity?: bigint;
unseen?: number;
highestModSeq?: bigint;
}
export interface StatusQuery {
messages?: boolean;
recent?: boolean;
uidNext?: boolean;
uidValidity?: boolean;
unseen?: boolean;
highestModseq?: boolean;
}
They have a different structure.
export interface StatusObject {
path: string;
uid?: number;
}
export interface StatusQuery {
uidNext?: boolean;
}
Therefore, they cannot be StatusQuery extends StatusObject or StatusObject extends StatusQuery.
Re-ping @jeffreyratton98, @martin-badin, @Grayson-code: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @b0939261761. (Ping @jeffreyratton98, @Grayson-code.) |
⏳ Hi @b0939261761, It's been a few days since this PR was approved by martin-badin and we're waiting for a DT maintainer to give a review. If you would like to short-circuit this wait, you can edit some of the test files in the package which verify how the |
Ready to merge |
Please fill in this template.
npm test <package to test>
.Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tslint.json
should contain{ "extends": "@definitelytyped/dtslint/dt.json" }
, and no additional rules.tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.If changing an existing definition:
If removing a declaration:
notNeededPackages.json
.