Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list options and fix status object #64482

Conversation

b0939261761
Copy link
Contributor

@b0939261761 b0939261761 commented Feb 25, 2023

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 25, 2023

@b0939261761 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 64482,
  "author": "b0939261761",
  "headCommitOid": "a83784a6325f77c149058b5a6f79ff51d7dba635",
  "mergeBaseOid": "055ec5302dd094d1fc5fe24e02905a89e3a5b2a5",
  "lastPushDate": "2023-02-25T09:20:05.000Z",
  "lastActivityDate": "2023-03-18T06:47:05.000Z",
  "mergeOfferDate": "2023-03-17T17:29:19.000Z",
  "mergeRequestDate": "2023-03-18T06:47:05.000Z",
  "mergeRequestUser": "martin-badin",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "imapflow",
      "kind": "edit",
      "files": [
        {
          "path": "types/imapflow/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "jeffreyratton98",
        "martin-badin",
        "grayson-code"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2023-03-17T17:28:33.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "martin-badin",
      "date": "2023-03-15T12:59:10.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1445039610,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Untested Change This PR does not touch tests label Feb 25, 2023
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Feb 25, 2023
@typescript-bot
Copy link
Contributor

🔔 @jeffreyratton98 @martin-badin @Grayson-code — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Feb 25, 2023
@@ -293,7 +296,7 @@ export interface SearchObject {

export interface StatusObject {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can extend this interface from StatusQuery. The interface has the same properties.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export interface StatusObject {
    path: string;
    messages?: number;
    recent?: number;
    uid?: number;
    uidValidity?: bigint;
    unseen?: number;
    highestModSeq?: bigint;
}


export interface StatusQuery {
    messages?: boolean;
    recent?: boolean;
    uidNext?: boolean;
    uidValidity?: boolean;
    unseen?: boolean;
    highestModseq?: boolean;
}

They have a different structure.

export interface StatusObject {
  path: string;
  uid?: number;
}

export interface StatusQuery {
  uidNext?: boolean;
}

Therefore, they cannot be StatusQuery extends StatusObject or StatusObject extends StatusQuery.

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Mar 8, 2023
@typescript-bot
Copy link
Contributor

Re-ping @jeffreyratton98, @martin-badin, @Grayson-code:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 15, 2023

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @b0939261761.

(Ping @jeffreyratton98, @Grayson-code.)

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Needs Maintainer Action in New Pull Request Status Board Mar 15, 2023
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Mar 15, 2023
@typescript-bot
Copy link
Contributor

⏳ Hi @b0939261761,

It's been a few days since this PR was approved by martin-badin and we're waiting for a DT maintainer to give a review.

If you would like to short-circuit this wait, you can edit some of the test files in the package which verify how the .d.ts files work. This would allow the PR to be merged by you or the DT module owners after a re-review.

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Mar 17, 2023
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board Mar 17, 2023
@martin-badin
Copy link
Contributor

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Mar 18, 2023
@typescript-bot typescript-bot merged commit 0b19d1e into DefinitelyTyped:master Mar 18, 2023
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants