Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d3-selection: add generic func parameters to selection.call #64492

Merged

Conversation

ambar-arkin
Copy link
Contributor

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/d3/d3-selection#selection_call
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 26, 2023

@ambar-arkin Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

@ambar-arkin: I see that you have added yourself as an owner, are you sure you want to become an owner?

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 64492,
  "author": "ambar-arkin",
  "headCommitOid": "f10f8871dd3ad074ba3b1ac4e2e80d3e85a364b6",
  "mergeBaseOid": "fa1941eec2a45c2f7eaed18b9042294e17e77302",
  "lastPushDate": "2023-02-26T19:13:57.000Z",
  "lastActivityDate": "2023-03-17T17:34:45.000Z",
  "mergeOfferDate": "2023-03-17T17:30:30.000Z",
  "mergeRequestDate": "2023-03-17T17:34:45.000Z",
  "mergeRequestUser": "ambar-arkin",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "d3-selection",
      "kind": "edit",
      "files": [
        {
          "path": "types/d3-selection/d3-selection-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/d3-selection/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "tomwanzek",
        "gustavderdrache",
        "borisyankov",
        "denisname",
        "Methuselah96"
      ],
      "addedOwners": [
        "ambar-arkin"
      ],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2023-03-17T17:29:43.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1445441530,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Edits Owners This PR adds or removes owners Popular package This PR affects a popular package (as counted by NPM download counts). labels Feb 26, 2023
@typescript-bot
Copy link
Contributor

🔔 @tomwanzek @gustavderdrache @borisyankov @denisname @Methuselah96 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Feb 26, 2023
@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Mar 10, 2023
@typescript-bot
Copy link
Contributor

Re-ping @tomwanzek, @gustavderdrache, @borisyankov, @denisname, @Methuselah96:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Mar 17, 2023
@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @ambar-arkin.

(Ping @tomwanzek, @gustavderdrache, @borisyankov, @denisname, @Methuselah96.)

@@ -5,6 +5,7 @@
// Boris Yankov <https://github.com/borisyankov>
// denisname <https://github.com/denisname>
// Nathan Bierema <https://github.com/Methuselah96>
// Ambar Mutha <https://github.com/ambar-arkin>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you looking to become an owner of this package, get pinged on PRs, etc? If you're just looking for credit, we do that via the git history and this could be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am interested in becoming an owner and helping review PRs.

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Mar 17, 2023
@typescript-bot
Copy link
Contributor

@ambar-arkin: Everything looks good here. I am ready to merge this PR (at f10f887) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@tomwanzek, @gustavderdrache, @borisyankov, @denisname, @Methuselah96: you can do this too.)

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board Mar 17, 2023
@ambar-arkin
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Mar 17, 2023
@typescript-bot typescript-bot merged commit d172d3e into DefinitelyTyped:master Mar 17, 2023
@ambar-arkin ambar-arkin deleted the d3-selection_call-generic branch March 17, 2023 18:25
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits Owners This PR adds or removes owners Maintainer Approved Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants