-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type definitions for postcss-resolve-nested-selector #64721
Add type definitions for postcss-resolve-nested-selector #64721
Conversation
@remcohaszing Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 64721,
"author": "remcohaszing",
"headCommitOid": "40ff2f70b9366ef4d039532ab12595dda7ed9909",
"mergeBaseOid": "559164afb72dfe6b648927e83cb394a1cb938ad9",
"lastPushDate": "2023-03-13T15:07:59.000Z",
"lastActivityDate": "2023-03-13T21:48:13.000Z",
"mergeOfferDate": "2023-03-13T20:21:35.000Z",
"mergeRequestDate": "2023-03-13T21:48:13.000Z",
"mergeRequestUser": "remcohaszing",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "postcss-resolve-nested-selector",
"kind": "add",
"files": [
{
"path": "types/postcss-resolve-nested-selector/index.d.ts",
"kind": "definition"
},
{
"path": "types/postcss-resolve-nested-selector/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/postcss-resolve-nested-selector/postcss-resolve-nested-selector-tests.ts",
"kind": "test"
},
{
"path": "types/postcss-resolve-nested-selector/tsconfig.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.lib.0`)"
},
{
"path": "types/postcss-resolve-nested-selector/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"remcohaszing",
"ybiquitous"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2023-03-13T20:20:48.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1466332821,
"ciResult": "pass"
} |
🔔 @remcohaszing — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
"compilerOptions": { | ||
"module": "commonjs", | ||
"lib": [ | ||
"es2018" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been altered, because postcss
depends on it.
@remcohaszing: Everything looks good here. I am ready to merge this PR (at 40ff2f7) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
Ready to merge |
This has been extracted from
https://github.com/stylelint/stylelint/blob/main/types/postcss-resolve-nested-selector/index.d.ts.
npm test <package to test>
.If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tslint.json
should contain{ "extends": "@definitelytyped/dtslint/dt.json" }
, and no additional rules.tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.@ybiquitous I added you as a co-maintainer, because you wrote them originally in the Stylelint repository. If you don’t want this, please let me know and I’ll remove it.