-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: ran eslint-plugin-jsdoc/check-tag-names autofixer #65080
chore: ran eslint-plugin-jsdoc/check-tag-names autofixer #65080
Conversation
@@ -510,15 +510,13 @@ declare module 'angular' { | |||
/** | |||
* Sets the `aria-describedby` property on the modal. | |||
* The string should be an id (without the leading '#') pointing to the element that describes your modal. | |||
* @type {string} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing @type
is the most common change in the rule. This instance is a good exemplar - the type is inaccurate!
@@ -17,7 +17,6 @@ declare namespace asana { | |||
* Constructs a Client with instances of all the resources using the dispatcher. | |||
* It also keeps a reference to the dispatcher so that way the end user can have | |||
* access to it. | |||
* @class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@class
is unnecessary when decorating a new
signature. It's implied by it being new
. See also @constructor
.
@@ -382,7 +360,6 @@ declare namespace asana { | |||
* be either the object returned from an access token request (which | |||
* contains the token and some other metadata) or just the `access_token` | |||
* field. | |||
* @constructor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@constructor
is unnecessary when decorating a new
signature. It's implied by it being new
. See also @class
.
@@ -259,7 +259,6 @@ function simple(prefix: string) { | |||
* A DocumentDB stored procedure that bulk deletes documents for a given query.<br/> | |||
* Note: You may need to execute this sproc multiple times (depending whether the sproc is able to delete every document within the execution timeout limit). | |||
* | |||
* @function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@function
is unnecessary when describing something typed as a function.
@@ -404,7 +404,6 @@ declare module 'durandal/binder' { | |||
declare module 'durandal/activator' { | |||
/** | |||
* The default settings used by activators. | |||
* @property {ActivatorSettings} defaults |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@property
is generally redundant, as the TS syntax indicates what's a property. Additionally, this is ... sort of inaccurate? Unclear what "property" means in the context of a module export.
d2d2ff9
to
cfb3f1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, and left some comments in places that could improve. (Although any improvement is welcome.)
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. angular-ui-bootstrap (unpkg)was missing the following properties:
as well as these 1 other properties...trimEnd confidence (unpkg)was missing the following properties:
express-brute-memcached (unpkg)was missing the following properties:
The most common way to resolve this error is to use 'export =' syntax.
express-brute (unpkg)was missing the following properties:
figlet (unpkg)was missing the following properties:
firebase-token-generator (unpkg)was missing the following properties:
jsts (unpkg)was missing the following properties:
as well as these 1 other properties...triangulate lokijs (unpkg)was missing the following properties:
loopback (unpkg)was missing the following properties:
as well as these 15 other properties...template, createModel, configureModel, findModel, getModel, getModelByType, createDataSource, memory, DataSource, Connector, Memory, Mail, Remote, GeoPoint, ValidationError memwatch-next (unpkg)was missing the following properties:
as well as these 10 other properties...setMaxListeners, getMaxListeners, listeners, rawListeners, emit, listenerCount, prependListener, prependOnceListener, eventNames, gc ng-file-upload (unpkg)was missing the following properties:
as well as these 1 other properties...trimEnd nodal (unpkg)was missing the following properties:
onfleet__node-onfleet (unpkg)was missing the following properties:
page (unpkg)was missing the following properties:
The most common way to resolve this error is to use 'export =' syntax.
as well as these 16 other properties...start, stop, show, back, redirect, replace, dispatch, exit, configure, sameOrigin, clickHandler, create, len, current, Context, Route restify (unpkg)was missing the following properties:
sat (unpkg)was missing the following properties:
selenium-webdriver (unpkg)was missing the following properties:
sequelize (unpkg)was missing the following properties:
simplesmtp (unpkg)was missing the following properties:
tuya-panel-kit (unpkg)was missing the following properties:
twitter-stream-channels (unpkg)was missing the following properties:
winjs (unpkg)was missing the following properties:
as well as these 40 other properties...LightDismissableElement, ModalElement, shown, hidden, updated, isShown, isTopmost, keyDown, keyUp, keyPress, ClassNames, EventNames, actionAreaCommandWidth, actionAreaSeparatorWidth, actionAreaOverflowButtonWidth, overflowCommandHeight, overflowSeparatorHeight, controlMinWidth, overflowAreaMaxWidth, heightOfMinimal, heightOfCompact, contentMenuCommandDefaultLabel, defaultClosedDisplayMode, defaultOpened, defaultOverflowDirection, typeSeparator, typeContent, typeButton, typeToggle, typeFlyout, commandSelector, primaryCommandSection, secondaryCommandSection, OverflowDirection, OpenCloseMachine, ToolBar, SplitView, SplitViewPaneToggle, defaultPlacement, AppBar |
@sandersn I think the code changes are ready for review from authors. I'm hesitant to open a PR that touches almost ~200 packages - and also hesitant to open almost ~200 PRs 😂. Is there a way you'd want me to request review? |
I normally split everything into 1 p For relatively uncontroversial and required changes that touch everything, 1 PR is fine and I just wait for a review by a DT maintainer. This change is not required but I hope it's not controversial. So I think a single PR is fine. You might split out fibjs separately since it has so many files. |
7d9cee3
to
5ca12f2
Compare
@JoshuaKGoldberg Thank you for submitting this PR! This is a live comment which I will keep updated. 93 packages in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 65080,
"author": "JoshuaKGoldberg",
"headCommitOid": "5ca12f2b5b63b24e2049d71cbcb36724080363bf",
"mergeBaseOid": "7bf71beda114bfce04410b4bf6c4b674856b8916",
"lastPushDate": "2023-04-27T15:18:19.000Z",
"lastActivityDate": "2023-04-29T03:46:40.000Z",
"mergeOfferDate": "2023-04-28T19:38:38.000Z",
"mergeRequestDate": "2023-04-29T03:46:40.000Z",
"mergeRequestUser": "JoshuaKGoldberg",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": true,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "angular-ui-bootstrap",
"kind": "edit",
"files": [
{
"path": "types/angular-ui-bootstrap/index.d.ts",
"kind": "definition"
}
],
"owners": [
"xt0rted",
"ry8806",
"alfiej",
"Igorbek"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "app-root-path",
"kind": "edit",
"files": [
{
"path": "types/app-root-path/index.d.ts",
"kind": "definition"
}
],
"owners": [
"shantmarouti"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "asana",
"kind": "edit",
"files": [
{
"path": "types/asana/index.d.ts",
"kind": "definition"
}
],
"owners": [
"tkqubo",
"tasyp",
"filipposarzana",
"szlori",
"apiology"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "bigint",
"kind": "edit",
"files": [
{
"path": "types/bigint/index.d.ts",
"kind": "definition"
}
],
"owners": [
"Evgenus"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "chai",
"kind": "edit",
"files": [
{
"path": "types/chai/index.d.ts",
"kind": "definition"
}
],
"owners": [
"Bartvds",
"AGBrown",
"olivr70",
"mwistrand",
"shaunluttin",
"micksatana",
"ErikSchierboom",
"bparan",
"CXuesong",
"joeykilpatrick"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "chrome-apps",
"kind": "edit",
"files": [
{
"path": "types/chrome-apps/index.d.ts",
"kind": "definition"
}
],
"owners": [
"niikoo",
"AdamLay",
"mzsm",
"RReverser",
"pyle",
"matthewkimber",
"otiai10",
"rreverser",
"sreimer15"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "cldrjs",
"kind": "edit",
"files": [
{
"path": "types/cldrjs/index.d.ts",
"kind": "definition"
}
],
"owners": [
"RamanBut-Husaim",
"gcastre"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "confidence",
"kind": "edit",
"files": [
{
"path": "types/confidence/index.d.ts",
"kind": "definition"
}
],
"owners": [
"jppellerin"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "connect-timeout",
"kind": "edit",
"files": [
{
"path": "types/connect-timeout/index.d.ts",
"kind": "definition"
}
],
"owners": [
"cyrilschumacher"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "decorum",
"kind": "edit",
"files": [
{
"path": "types/decorum/index.d.ts",
"kind": "definition"
}
],
"owners": [
"dflor003"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "documentdb-server",
"kind": "edit",
"files": [
{
"path": "types/documentdb-server/documentdb-server-tests.ts",
"kind": "test"
}
],
"owners": [
"johndowns"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "durandal",
"kind": "edit",
"files": [
{
"path": "types/durandal/index.d.ts",
"kind": "definition"
}
],
"owners": [
"BlueSpire"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "dwt",
"kind": "edit",
"files": [
{
"path": "types/dwt/v12/index.d.ts",
"kind": "definition"
},
{
"path": "types/dwt/v13/addon.ocr.d.ts",
"kind": "definition"
},
{
"path": "types/dwt/v13/addon.pdf.d.ts",
"kind": "definition"
},
{
"path": "types/dwt/v13/addon.webcam.d.ts",
"kind": "definition"
},
{
"path": "types/dwt/v13/index.d.ts",
"kind": "definition"
},
{
"path": "types/dwt/v14/Dynamsoft.d.ts",
"kind": "definition"
},
{
"path": "types/dwt/v14/addon.ocr.d.ts",
"kind": "definition"
},
{
"path": "types/dwt/v14/addon.pdf.d.ts",
"kind": "definition"
},
{
"path": "types/dwt/v14/addon.webcam.d.ts",
"kind": "definition"
}
],
"owners": [
"yushulx",
"jbh",
"lincoln2018",
"Tom-Dynamsoft",
"dsueltenfuss"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "dynatable",
"kind": "edit",
"files": [
{
"path": "types/dynatable/index.d.ts",
"kind": "definition"
}
],
"owners": [
"francoismassart"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "ember",
"kind": "edit",
"files": [
{
"path": "types/ember/v1/index.d.ts",
"kind": "definition"
}
],
"owners": [
"chriskrycho",
"jamescdavis",
"wagenet",
"dfreeman"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "express-brute-memcached",
"kind": "edit",
"files": [
{
"path": "types/express-brute-memcached/index.d.ts",
"kind": "definition"
}
],
"owners": [
"cyrilschumacher"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "express-brute",
"kind": "edit",
"files": [
{
"path": "types/express-brute/index.d.ts",
"kind": "definition"
}
],
"owners": [
"cyrilschumacher"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "fabric",
"kind": "edit",
"files": [
{
"path": "types/fabric/fabric-impl.d.ts",
"kind": "definition"
}
],
"owners": [
"oklemencic",
"joewashear007",
"mrand01",
"NotWoods",
"bmartinson",
"RogerioTeixeira",
"BradleyHill",
"bmkrol823",
"glenngartner",
"codertx",
"mike667",
"nataliemarleny",
"buzzyboy",
"nkdevil"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "figlet",
"kind": "edit",
"files": [
{
"path": "types/figlet/index.d.ts",
"kind": "definition"
}
],
"owners": [
"DefinitelyTyped"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "firebase-token-generator",
"kind": "edit",
"files": [
{
"path": "types/firebase-token-generator/index.d.ts",
"kind": "definition"
}
],
"owners": [
"dotdotcommadot"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "firebird",
"kind": "edit",
"files": [
{
"path": "types/firebird/index.d.ts",
"kind": "definition"
}
],
"owners": [
"karak"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "get-intrinsic",
"kind": "edit",
"files": [
{
"path": "types/get-intrinsic/scripts/intrinsics-data.ts",
"kind": "test"
}
],
"owners": [
"ljharb",
"ExE-Boss"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "glidejs",
"kind": "edit",
"files": [
{
"path": "types/glidejs/index.d.ts",
"kind": "definition"
}
],
"owners": [
"milanjaros"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "go",
"kind": "edit",
"files": [
{
"path": "types/go/index.d.ts",
"kind": "definition"
}
],
"owners": [
"NorthwoodsSoftware"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "google.visualization",
"kind": "edit",
"files": [
{
"path": "types/google.visualization/index.d.ts",
"kind": "definition"
}
],
"owners": [
"danludwig",
"gmoore-sjcorg",
"danmana",
"mlcheng",
"IvanBisultanov",
"glebm",
"shrujalshah28",
"dckorben",
"martin-badin"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "googlemaps.infobubble",
"kind": "edit",
"files": [
{
"path": "types/googlemaps.infobubble/index.d.ts",
"kind": "definition"
}
],
"owners": [
"Dashue"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "gulp-ruby-sass",
"kind": "edit",
"files": [
{
"path": "types/gulp-ruby-sass/index.d.ts",
"kind": "definition"
}
],
"owners": [
"agnislav"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "heremaps",
"kind": "edit",
"files": [
{
"path": "types/heremaps/index.d.ts",
"kind": "definition"
}
],
"owners": [
"Josh-ES",
"denyo",
"fx88",
"life777",
"DaSchTour"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "i18next-node-fs-backend",
"kind": "edit",
"files": [
{
"path": "types/i18next-node-fs-backend/index.d.ts",
"kind": "definition"
}
],
"owners": [
"cyrilschumacher",
"lenovouser"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "imap",
"kind": "edit",
"files": [
{
"path": "types/imap/index.d.ts",
"kind": "definition"
}
],
"owners": [
"psnider"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "jpm",
"kind": "edit",
"files": [
{
"path": "types/jpm/index.d.ts",
"kind": "definition"
}
],
"owners": [
"DefinitelyTyped"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "jquery.simplepagination",
"kind": "edit",
"files": [
{
"path": "types/jquery.simplepagination/index.d.ts",
"kind": "definition"
}
],
"owners": [
"nvivo"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "jquery.total-storage",
"kind": "edit",
"files": [
{
"path": "types/jquery.total-storage/index.d.ts",
"kind": "definition"
}
],
"owners": [
"JeremyCBrooks"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "jstree",
"kind": "edit",
"files": [
{
"path": "types/jstree/index.d.ts",
"kind": "definition"
}
],
"owners": [
"adaskothebeast"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "jsts",
"kind": "edit",
"files": [
{
"path": "types/jsts/index.d.ts",
"kind": "definition"
}
],
"owners": [
"StephaneAlie",
"jrocha"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "jsuri",
"kind": "edit",
"files": [
{
"path": "types/jsuri/index.d.ts",
"kind": "definition"
}
],
"owners": [
"coldacid",
"flqw"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "knockout.validation",
"kind": "edit",
"files": [
{
"path": "types/knockout.validation/index.d.ts",
"kind": "definition"
}
],
"owners": [
"danludwig"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "leadfoot",
"kind": "edit",
"files": [
{
"path": "types/leadfoot/index.d.ts",
"kind": "definition"
}
],
"owners": [
"theintern"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "leaflet",
"kind": "edit",
"files": [
{
"path": "types/leaflet/v0/index.d.ts",
"kind": "definition"
}
],
"owners": [
"alejo90",
"atd-schubert",
"mcauer",
"ronikar",
"life777",
"henrythasler",
"captain-igloo",
"someonewithpc"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "lokijs",
"kind": "edit",
"files": [
{
"path": "types/lokijs/index.d.ts",
"kind": "definition"
}
],
"owners": [
"TeamworkGuy2",
"thomasconner"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "lolex",
"kind": "edit",
"files": [
{
"path": "types/lolex/index.d.ts",
"kind": "definition"
}
],
"owners": [
"Nemo157",
"rogierschouten",
"zyishai"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "loopback",
"kind": "edit",
"files": [
{
"path": "types/loopback/index.d.ts",
"kind": "definition"
}
],
"owners": [
"kattsushi",
"enko",
"sequoia",
"drmikecrowe",
"karimsa"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "mapbox-gl",
"kind": "edit",
"files": [
{
"path": "types/mapbox-gl/index.d.ts",
"kind": "definition"
},
{
"path": "types/mapbox-gl/v1/index.d.ts",
"kind": "definition"
}
],
"owners": [
"dobrud",
"macobo",
"dmytro-gokun",
"LiamAttClarke",
"life777",
"amxfonseca",
"Nosfit",
"mbullington",
"pascaloliv",
"mschilde"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "mapsjs",
"kind": "edit",
"files": [
{
"path": "types/mapsjs/index.d.ts",
"kind": "definition"
}
],
"owners": [
"davismj"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "memwatch-next",
"kind": "edit",
"files": [
{
"path": "types/memwatch-next/index.d.ts",
"kind": "definition"
}
],
"owners": [
"cyrilschumacher"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "meteor-roles",
"kind": "edit",
"files": [
{
"path": "types/meteor-roles/index.d.ts",
"kind": "definition"
},
{
"path": "types/meteor-roles/meteor-roles-tests.ts",
"kind": "test"
}
],
"owners": [
"vangorra",
"mattmm3d"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "neo4j",
"kind": "edit",
"files": [
{
"path": "types/neo4j/index.d.ts",
"kind": "definition"
}
],
"owners": [
"cyrilschumacher"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "ng-file-upload",
"kind": "edit",
"files": [
{
"path": "types/ng-file-upload/index.d.ts",
"kind": "definition"
}
],
"owners": [
"johnnyreilly",
"thewarpaint"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "ngmap",
"kind": "edit",
"files": [
{
"path": "types/ngmap/index.d.ts",
"kind": "definition"
}
],
"owners": [
"nkovacic"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "nodal",
"kind": "edit",
"files": [
{
"path": "types/nodal/index.d.ts",
"kind": "definition"
}
],
"owners": [
"charrondev"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "nodemailer-stub-transport",
"kind": "edit",
"files": [
{
"path": "types/nodemailer-stub-transport/index.d.ts",
"kind": "definition"
}
],
"owners": [
"cyrilschumacher"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "nwsapi",
"kind": "edit",
"files": [
{
"path": "types/nwsapi/index.d.ts",
"kind": "definition"
}
],
"owners": [
"ExE-Boss"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "onfleet__node-onfleet",
"kind": "edit",
"files": [
{
"path": "types/onfleet__node-onfleet/Resources/Administrators.d.ts",
"kind": "definition"
},
{
"path": "types/onfleet__node-onfleet/Resources/Destinations.d.ts",
"kind": "definition"
},
{
"path": "types/onfleet__node-onfleet/Resources/Teams.d.ts",
"kind": "definition"
},
{
"path": "types/onfleet__node-onfleet/Resources/Workers.d.ts",
"kind": "definition"
}
],
"owners": [
"marcobeltempo",
"neilpoulin"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "openfin",
"kind": "edit",
"files": [
{
"path": "types/openfin/_v2/api/application/application.d.ts",
"kind": "definition"
},
{
"path": "types/openfin/_v2/api/clipboard/clipboard.d.ts",
"kind": "definition"
},
{
"path": "types/openfin/_v2/api/external-application/external-application.d.ts",
"kind": "definition"
},
{
"path": "types/openfin/_v2/api/frame/frame.d.ts",
"kind": "definition"
},
{
"path": "types/openfin/_v2/api/notification/notification.d.ts",
"kind": "definition"
},
{
"path": "types/openfin/_v2/api/platform/layout.d.ts",
"kind": "definition"
},
{
"path": "types/openfin/_v2/api/system/system.d.ts",
"kind": "definition"
},
{
"path": "types/openfin/_v2/api/view/view.d.ts",
"kind": "definition"
},
{
"path": "types/openfin/_v2/api/window/window.d.ts",
"kind": "definition"
},
{
"path": "types/openfin/v50/_v2/api/application/application.d.ts",
"kind": "definition"
},
{
"path": "types/openfin/v50/_v2/api/clipboard/clipboard.d.ts",
"kind": "definition"
},
{
"path": "types/openfin/v50/_v2/api/external-application/external-application.d.ts",
"kind": "definition"
},
{
"path": "types/openfin/v50/_v2/api/external-window/external-window.d.ts",
"kind": "definition"
},
{
"path": "types/openfin/v50/_v2/api/frame/frame.d.ts",
"kind": "definition"
},
{
"path": "types/openfin/v50/_v2/api/notification/notification.d.ts",
"kind": "definition"
},
{
"path": "types/openfin/v50/_v2/api/platform/layout.d.ts",
"kind": "definition"
},
{
"path": "types/openfin/v50/_v2/api/system/system.d.ts",
"kind": "definition"
},
{
"path": "types/openfin/v50/_v2/api/view/view.d.ts",
"kind": "definition"
},
{
"path": "types/openfin/v50/_v2/api/window/window.d.ts",
"kind": "definition"
},
{
"path": "types/openfin/v50/index.d.ts",
"kind": "definition"
}
],
"owners": [
"chrisbarker",
"rdepena",
"whyn07m3",
"licui3936",
"tomer-openfin"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "packery",
"kind": "edit",
"files": [
{
"path": "types/packery/index.d.ts",
"kind": "definition"
}
],
"owners": [
"piraveen",
"hanssens"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "page",
"kind": "edit",
"files": [
{
"path": "types/page/index.d.ts",
"kind": "definition"
}
],
"owners": [
"altano",
"43081j",
"peterblazejewicz"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "parse",
"kind": "edit",
"files": [
{
"path": "types/parse/v1/index.d.ts",
"kind": "definition"
}
],
"owners": [
"ullisenmedia",
"dpoetzsch",
"jaeggerr",
"flavionegrao",
"wesleygrimes",
"owsas",
"agoldis",
"AlexandreHetu",
"dplewis",
"yomybaby",
"pocketcolin",
"rdhelms",
"jlnquere",
"tybi",
"jeffgukang",
"buitanloc",
"JeromeDeLeon",
"kentrh",
"swittk"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "plupload",
"kind": "edit",
"files": [
{
"path": "types/plupload/index.d.ts",
"kind": "definition"
}
],
"owners": [
"patrickbussmann"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "progressbar.js",
"kind": "edit",
"files": [
{
"path": "types/progressbar.js/index.d.ts",
"kind": "definition"
}
],
"owners": [
"peterblazejewicz"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "qunit",
"kind": "edit",
"files": [
{
"path": "types/qunit/index.d.ts",
"kind": "definition"
}
],
"owners": [
"waratuman",
"mike-north",
"sechel",
"chriskrycho",
"dfreeman",
"jamescdavis",
"Krinkle"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "react-foundation",
"kind": "edit",
"files": [
{
"path": "types/react-foundation/enums.d.ts",
"kind": "definition"
}
],
"owners": [
"danielearwicker"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "redux-optimistic-ui",
"kind": "edit",
"files": [
{
"path": "types/redux-optimistic-ui/index.d.ts",
"kind": "definition"
}
],
"owners": [
"asvetliakov"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "ref-struct-di",
"kind": "edit",
"files": [
{
"path": "types/ref-struct-di/index.d.ts",
"kind": "definition"
}
],
"owners": [
"keerthi16",
"KiranNiranjan"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "ref-struct",
"kind": "edit",
"files": [
{
"path": "types/ref-struct/index.d.ts",
"kind": "definition"
}
],
"owners": [
"loyd"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "ref-union-di",
"kind": "edit",
"files": [
{
"path": "types/ref-union-di/index.d.ts",
"kind": "definition"
}
],
"owners": [
"keerthi16",
"KiranNiranjan"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "ref-union",
"kind": "edit",
"files": [
{
"path": "types/ref-union/index.d.ts",
"kind": "definition"
}
],
"owners": [
"loyd"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "restify",
"kind": "edit",
"files": [
{
"path": "types/restify/index.d.ts",
"kind": "definition"
},
{
"path": "types/restify/v5/index.d.ts",
"kind": "definition"
}
],
"owners": [
"blittle",
"leanazulyoro",
"mgebundy",
"alcmoraes",
"quinnlangille",
"GaikwadPratik"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "restler",
"kind": "edit",
"files": [
{
"path": "types/restler/index.d.ts",
"kind": "definition"
}
],
"owners": [
"cyrilschumacher"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "rosie",
"kind": "edit",
"files": [
{
"path": "types/rosie/index.d.ts",
"kind": "definition"
}
],
"owners": [
"abner",
"subvertallchris",
"abukurov",
"adam187"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "roslib",
"kind": "edit",
"files": [
{
"path": "types/roslib/index.d.ts",
"kind": "definition"
}
],
"owners": [
"Pro",
"dgorobopec",
"alumag"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "russian-nouns-js",
"kind": "edit",
"files": [
{
"path": "types/russian-nouns-js/src/Engine.d.ts",
"kind": "definition"
}
],
"owners": [
"RusAnonym"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "sass-graph",
"kind": "edit",
"files": [
{
"path": "types/sass-graph/index.d.ts",
"kind": "definition"
}
],
"owners": [
"marvinhagemeister"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "sat",
"kind": "edit",
"files": [
{
"path": "types/sat/index.d.ts",
"kind": "definition"
}
],
"owners": [
"omni360"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "selenium-webdriver",
"kind": "edit",
"files": [
{
"path": "types/selenium-webdriver/chrome.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/edge.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/http.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/ie.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/index.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/lib/by.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/lib/capabilities.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/lib/command.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/lib/error.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/lib/input.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/lib/logging.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/lib/virtual_authenticator.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/lib/webdriver.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/safari.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v2/chrome.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v2/firefox.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v2/http.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v2/index.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v2/remote.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v2/safari.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v3/chrome.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v3/firefox.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v3/http.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v3/index.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v3/remote.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v3/safari.d.ts",
"kind": "definition"
}
],
"owners": [
"BillArmstrong",
"Kuniwak",
"cnishina",
"SupernaviX",
"bendxn",
"oddui",
"beta-vulgaris",
"Dzenly",
"AutomatedTester",
"1pete",
"SinghHrmn",
"shubhsheth"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "sequelize",
"kind": "edit",
"files": [
{
"path": "types/sequelize/index.d.ts",
"kind": "definition"
},
{
"path": "types/sequelize/v3/index.d.ts",
"kind": "definition"
}
],
"owners": [
"samuelneff",
"codeanimal",
"drinchev",
"babolivier",
"kukoo1",
"oktapodia",
"morpheusxaut",
"TitaneBoy",
"zjy01",
"Raigen",
"todd",
"nrschultz",
"thomas-b",
"Antoine38660",
"smff",
"truongkhanhduy95",
"emmanuelgautier",
"dancrumb",
"lalayueh",
"rohitsud"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "showdown",
"kind": "edit",
"files": [
{
"path": "types/showdown/index.d.ts",
"kind": "definition"
}
],
"owners": [
"hamedbaatour",
"cbowdon",
"tan9",
"arielsaldana",
"yisraelx"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "simplesmtp",
"kind": "edit",
"files": [
{
"path": "types/simplesmtp/index.d.ts",
"kind": "definition"
}
],
"owners": [
"rogierschouten"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "slickgrid",
"kind": "edit",
"files": [
{
"path": "types/slickgrid/index.d.ts",
"kind": "definition"
}
],
"owners": [
"jbaldwin"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "smart-fox-server",
"kind": "edit",
"files": [
{
"path": "types/smart-fox-server/index.d.ts",
"kind": "definition"
}
],
"owners": [
"ChanceM"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "smtp-server",
"kind": "edit",
"files": [
{
"path": "types/smtp-server/v1/index.d.ts",
"kind": "definition"
}
],
"owners": [
"markisme",
"Taisiias",
"dex4er",
"paul-oms"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "sparkpost",
"kind": "edit",
"files": [
{
"path": "types/sparkpost/v1/index.d.ts",
"kind": "definition"
}
],
"owners": [
"geoffreak",
"bondz",
"vvu"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "suitescript",
"kind": "edit",
"files": [
{
"path": "types/suitescript/index.d.ts",
"kind": "definition"
}
],
"owners": [
"darrenhillconsulting"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "trunk8",
"kind": "edit",
"files": [
{
"path": "types/trunk8/index.d.ts",
"kind": "definition"
}
],
"owners": [
"niemyjski"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "tuya-panel-kit",
"kind": "edit",
"files": [
{
"path": "types/tuya-panel-kit/index.d.ts",
"kind": "definition"
}
],
"owners": [
"youngjuning",
"ShinyLeee"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "twitter-stream-channels",
"kind": "edit",
"files": [
{
"path": "types/twitter-stream-channels/index.d.ts",
"kind": "definition"
}
],
"owners": [
"adrianbardan"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "typeahead.js",
"kind": "edit",
"files": [
{
"path": "types/typeahead.js/index.d.ts",
"kind": "definition"
}
],
"owners": [
"igochkov",
"gjunge"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "vitalsigns",
"kind": "edit",
"files": [
{
"path": "types/vitalsigns/index.d.ts",
"kind": "definition"
}
],
"owners": [
"cyrilschumacher"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "wallabyjs",
"kind": "edit",
"files": [
{
"path": "types/wallabyjs/index.d.ts",
"kind": "definition"
}
],
"owners": [
"andrewconnell"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "winjs",
"kind": "edit",
"files": [
{
"path": "types/winjs/index.d.ts",
"kind": "definition"
},
{
"path": "types/winjs/v1/index.d.ts",
"kind": "definition"
},
{
"path": "types/winjs/v2/index.d.ts",
"kind": "definition"
}
],
"owners": [
"adamhewitt627",
"craigktreasure",
"xirzec"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "winreg",
"kind": "edit",
"files": [
{
"path": "types/winreg/index.d.ts",
"kind": "definition"
}
],
"owners": [
"RX14",
"BobBuehler"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "xrm",
"kind": "edit",
"files": [
{
"path": "types/xrm/index.d.ts",
"kind": "definition"
}
],
"owners": [
"mattngan",
"markusmauch",
"daryllabar",
"clownwilleatme",
"scottdurow",
"filcole",
"power-maverick"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "ydn-db",
"kind": "edit",
"files": [
{
"path": "types/ydn-db/ydn-db-tests.ts",
"kind": "test"
}
],
"owners": [
"yathit",
"gabrielmaldi"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "zeroclipboard",
"kind": "edit",
"files": [
{
"path": "types/zeroclipboard/index.d.ts",
"kind": "definition"
}
],
"owners": [
"ejsmith",
"niemyjski",
"balassy",
"leonyu"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "gabritto",
"date": "2023-04-28T19:36:32.000Z",
"isMaintainer": true
},
{
"type": "stale",
"reviewer": "sandersn",
"date": "2023-04-18T22:46:04.000Z",
"abbrOid": "d118bf3"
}
],
"mainBotCommentID": 1525915802,
"ciResult": "pass"
} |
People who would have been pingedxt0rted ry8806 alfiej Igorbek shantmarouti tkqubo tasyp filipposarzana szlori apiology Evgenus Bartvds AGBrown olivr70 mwistrand shaunluttin micksatana ErikSchierboom bparan CXuesong joeykilpatrick niikoo AdamLay mzsm RReverser pyle matthewkimber otiai10 rreverser sreimer15 RamanBut-Husaim gcastre jppellerin cyrilschumacher dflor003 johndowns BlueSpire yushulx jbh lincoln2018 Tom-Dynamsoft dsueltenfuss francoismassart chriskrycho jamescdavis wagenet dfreeman oklemencic joewashear007 mrand01 NotWoods bmartinson RogerioTeixeira BradleyHill bmkrol823 glenngartner codertx mike667 nataliemarleny buzzyboy nkdevil DefinitelyTyped dotdotcommadot karak ljharb ExE-Boss milanjaros NorthwoodsSoftware danludwig gmoore-sjcorg danmana mlcheng IvanBisultanov glebm shrujalshah28 dckorben martin-badin Dashue agnislav Josh-ES denyo fx88 life777 DaSchTour lenovouser psnider nvivo JeremyCBrooks adaskothebeast StephaneAlie jrocha coldacid flqw theintern alejo90 atd-schubert mcauer ronikar henrythasler captain-igloo someonewithpc TeamworkGuy2 thomasconner Nemo157 rogierschouten zyishai kattsushi enko sequoia drmikecrowe karimsa dobrud macobo dmytro-gokun LiamAttClarke amxfonseca Nosfit mbullington pascaloliv mschilde davismj vangorra mattmm3d johnnyreilly thewarpaint nkovacic charrondev marcobeltempo neilpoulin chrisbarker rdepena whyn07m3 licui3936 tomer-openfin piraveen hanssens altano 43081j peterblazejewicz ullisenmedia dpoetzsch jaeggerr flavionegrao wesleygrimes owsas agoldis AlexandreHetu dplewis yomybaby pocketcolin rdhelms jlnquere tybi jeffgukang buitanloc JeromeDeLeon kentrh swittk patrickbussmann waratuman mike-north sechel Krinkle danielearwicker asvetliakov keerthi16 KiranNiranjan loyd blittle leanazulyoro mgebundy alcmoraes quinnlangille GaikwadPratik abner subvertallchris abukurov adam187 Pro dgorobopec alumag RusAnonym marvinhagemeister omni360 BillArmstrong Kuniwak cnishina SupernaviX bendxn oddui beta-vulgaris Dzenly AutomatedTester 1pete SinghHrmn shubhsheth samuelneff codeanimal drinchev babolivier kukoo1 oktapodia morpheusxaut TitaneBoy zjy01 Raigen todd nrschultz thomas-b Antoine38660 smff truongkhanhduy95 emmanuelgautier dancrumb lalayueh rohitsud hamedbaatour cbowdon tan9 arielsaldana yisraelx jbaldwin ChanceM markisme Taisiias dex4er paul-oms geoffreak bondz vvu darrenhillconsulting niemyjski youngjuning ShinyLeee adrianbardan igochkov gjunge andrewconnell adamhewitt627 craigktreasure xirzec RX14 BobBuehler mattngan markusmauch daryllabar clownwilleatme scottdurow filcole power-maverick yathit gabrielmaldi ejsmith balassy leonyu |
@sandersn Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
@JoshuaKGoldberg: Everything looks good here. I am ready to merge this PR (at 5ca12f2) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
I ... guess I'll just go ahead then! 😄 Ready to merge |
Ready to merge |
…-tag-names autofixer by @JoshuaKGoldberg
Context: Part of part of #648, porting old TSLint rules to ESLint equivalents. Within migrating
no-redundant-jsdoc2
, this runs the auto-fixer from jsdoc/check-tag-names.jsdoc/check-tag-names
reports on JSDoc tags that are unnecessary. Here, we're using its{ typed: true }
option to look for JSDoc tags that are redundant in TypeScript.I used a very permissive ESLint config to avoid flagging library-specific tags or switching tag names unnecessarily (e.g.
@return
to@returns
)Starting off as a draft so we can discuss what changes might need to be made to
check-tag-names
. Each classification of change has a comment thread inline.