[ws] Reverts generics added to ServerOptions for @types/ws v8

[masterqwerty]

This reverts the changes from #65501 for @types/ws v8 which includes breaking changes released as a patch change that breaks the build for Angular projects using @angular-devkit/build-angular with versions older than 16 with the following error message:

Error: node_modules/@types/ws/index.d.ts:328:18 - error TS2315: Type 'Server' is not generic.

328         server?: HTTPServer<V> | HTTPSServer<V> | undefined;
                     ~~~~~~~~~~~~~


Error: node_modules/@types/ws/index.d.ts:328:34 - error TS2315: Type 'Server' is not generic.

328         server?: HTTPServer<V> | HTTPSServer<V> | undefined;
                                     ~~~~~~~~~~~~~~

This can be temporarily fixed by adding the following override config to your package.json:

"overrides": {
  "webpack-dev-server": {
    "@types/ws": "8.5.4"
  }
}

On top of releasing a patch for @types/ws v8, the generics would need to be released in @types/ws v9.

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#running-tests).

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: <>
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[typescript-bot]

@masterqwerty Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• ws — on npm, on unpkg
  • Config files to check:
    • ws/v8/OTHER_FILES.txt: not the expected form
    • ws/v8/index.d.mts: edited
    • ws/v8/package.json: not the expected form (check: exports)
    • ws/v8/tsconfig.json: not the expected form (check: compilerOptions.lib.0)

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ❌ Continuous integration tests have failed
• 🕐 A DT maintainer needs to approve changes which affect module config files

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 31 days — it is considered abandoned, and therefore closed!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 65849,
  "author": "masterqwerty",
  "headCommitOid": "45251b14b24c242502df9742f38fcd5572777818",
  "mergeBaseOid": "dd7882043c1d7cc5cf778372d24c883c441a8b1a",
  "lastPushDate": "2023-06-21T21:03:47.000Z",
  "lastActivityDate": "2023-07-20T15:07:37.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "ws",
      "kind": "edit",
      "files": [
        {
          "path": "types/ws/v8/OTHER_FILES.txt",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-other_filestxt)"
        },
        {
          "path": "types/ws/v8/index.d.mts",
          "kind": "package-meta",
          "suspect": "edited"
        },
        {
          "path": "types/ws/v8/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ws/v8/package.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-packagejson) (check: `exports`)"
        },
        {
          "path": "types/ws/v8/tsconfig.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.lib.0`)"
        },
        {
          "path": "types/ws/v8/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/ws/v8/ws-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "loyd",
        "mlamp",
        "TitaneBoy",
        "reduckted",
        "teidesu",
        "wojtkowiak",
        "k-yle",
        "cwadrupldijjit"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1601675642,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/45251b14b24c242502df9742f38fcd5572777818/checks?check_suite_id=13773563973"
}

[typescript-bot]

🔔 @loyd @mlamp @TitaneBoy @reduckted @teidesu @wojtkowiak @k-yle @cwadrupldijjit — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@masterqwerty The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[masterqwerty]

Any guidance on how to fix the error from the CI workflow? It's saying I'm not allowed to have a v8 sub-directory since the latest version of @types/ws is at version 8, but we'll need a version 9 for the new generics that were added in version 8.5.5, then a version 8.5.6 to revert back the breaking changes introduced into 8.5.5.

[typescript-bot]

@masterqwerty I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Jul 21st (in a week) if the issues aren't addressed.

[Muhammad-Altabba]

Hello,
The issue is still.
Thanks,

[typescript-bot]

@masterqwerty I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Aug 19th (in a week) if the issues aren't addressed.

[typescript-bot]

@masterqwerty To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you!