New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[plotly.js] Add missing data property on PlotlyHTMLElement. #65953
Conversation
@jychen630 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 65953,
"author": "jychen630",
"headCommitOid": "7409a8a0a3c61c06ccc370e8231906bae50fbbdb",
"mergeBaseOid": "3420adf4ca802933d360aced242b4a44ebca507d",
"lastPushDate": "2023-07-01T21:37:30.000Z",
"lastActivityDate": "2023-07-02T18:05:41.000Z",
"mergeOfferDate": "2023-07-02T17:29:13.000Z",
"mergeRequestDate": "2023-07-02T18:05:41.000Z",
"mergeRequestUser": "jychen630",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "plotly.js",
"kind": "edit",
"files": [
{
"path": "types/plotly.js/index.d.ts",
"kind": "definition"
},
{
"path": "types/plotly.js/test/index-tests.ts",
"kind": "test"
}
],
"owners": [
"chrisgervang",
"martinduparc",
"frederikaalund",
"taoqf",
"Dadstart",
"szechyjs",
"soorajpudiyadath",
"jonfreedman",
"meganrm",
"milesjos",
"skippercool",
"mtadams007",
"marnett-git",
"peterblazejewicz",
"brammitch",
"blizzardjessica",
"olegshilov",
"PabloGracia",
"jvgogh"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2023-07-02T17:28:26.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1616044209,
"ciResult": "pass"
} |
🔔 @chrisgervang @martinduparc @frederikaalund @taoqf @Dadstart @szechyjs @soorajpudiyadath @jonfreedman @meganrm @milesjos @SkipperCool @mtadams007 @marnett-git @peterblazejewicz @brammitch @blizzardjessica @olegshilov @PabloGracia @jvgogh — please review this PR in the next few days. Be sure to explicitly select |
@jychen630 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 65953,
"author": "jychen630",
"headCommitOid": "7409a8a0a3c61c06ccc370e8231906bae50fbbdb",
"mergeBaseOid": "3420adf4ca802933d360aced242b4a44ebca507d",
"lastPushDate": "2023-07-01T21:37:30.000Z",
"lastActivityDate": "2023-07-02T18:05:41.000Z",
"mergeOfferDate": "2023-07-02T17:29:13.000Z",
"mergeRequestDate": "2023-07-02T18:05:41.000Z",
"mergeRequestUser": "jychen630",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "plotly.js",
"kind": "edit",
"files": [
{
"path": "types/plotly.js/index.d.ts",
"kind": "definition"
},
{
"path": "types/plotly.js/test/index-tests.ts",
"kind": "test"
}
],
"owners": [
"chrisgervang",
"martinduparc",
"frederikaalund",
"taoqf",
"Dadstart",
"szechyjs",
"soorajpudiyadath",
"jonfreedman",
"meganrm",
"milesjos",
"skippercool",
"mtadams007",
"marnett-git",
"peterblazejewicz",
"brammitch",
"blizzardjessica",
"olegshilov",
"PabloGracia",
"jvgogh"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2023-07-02T17:28:26.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1616044209,
"ciResult": "pass"
} |
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. plotly.js (unpkg)was missing the following properties:
|
Signed-off-by: Junyao Chen <junyao.chen@nyu.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@jychen630 thanks!
@jychen630: Everything looks good here. I am ready to merge this PR (at 7409a8a) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@chrisgervang, @martinduparc, @frederikaalund, @taoqf, @Dadstart, @szechyjs, @soorajpudiyadath, @jonfreedman, @meganrm, @milesjos, @SkipperCool, @mtadams007, @marnett-git, @peterblazejewicz, @brammitch, @blizzardjessica, @olegshilov, @PabloGracia, @jvgogh: you can do this too.) |
Ready to merge |
…y on PlotlyHTMLElement. by @jychen630 Signed-off-by: Junyao Chen <junyao.chen@nyu.edu>
According to an example from the
plotly.js/src/plot_api/plot_api.js
, this reference, and documentation, aPlotlyHTMLElement
object should be able to accessdata
property. Suchdata
property is currently not supported. This PR fixes this.Testing and the rest of checklist are WIP.
npm test <package to test>
.If changing an existing definition: