Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for cypress-cdp #66237

Merged
merged 1 commit into from Aug 1, 2023
Merged

Add types for cypress-cdp #66237

merged 1 commit into from Aug 1, 2023

Conversation

froissant
Copy link
Contributor

Add types for cypress-cdp.

Adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

See bahmutov/cypress-cdp#27

@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 31, 2023

@froissant Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes when there are new packages added

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 66237,
  "author": "froissant",
  "headCommitOid": "0bc93f39598941b469e8294808d6bbe62acf907e",
  "mergeBaseOid": "27c92742527659cd443772444f00258dd518b4da",
  "lastPushDate": "2023-07-31T17:18:05.000Z",
  "lastActivityDate": "2023-08-01T19:38:58.000Z",
  "mergeOfferDate": "2023-08-01T19:33:06.000Z",
  "mergeRequestDate": "2023-08-01T19:38:58.000Z",
  "mergeRequestUser": "froissant",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "cypress-cdp",
      "kind": "add",
      "files": [
        {
          "path": "types/cypress-cdp/cypress-cdp-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/cypress-cdp/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/cypress-cdp/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/cypress-cdp/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/cypress-cdp/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "froissant",
        "LouisLoiseau"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2023-08-01T19:32:21.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1658817257,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the New Definition This PR creates a new definition package. label Jul 31, 2023
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Jul 31, 2023
@typescript-bot
Copy link
Contributor

🔔 @froissant — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Jul 31, 2023
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Jul 31, 2023
@typescript-bot
Copy link
Contributor

@froissant The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@froissant froissant closed this Aug 1, 2023
@typescript-bot typescript-bot removed this from Needs Author Action in New Pull Request Status Board Aug 1, 2023
@froissant froissant reopened this Aug 1, 2023
@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Aug 1, 2023
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Aug 1, 2023
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Aug 1, 2023
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Aug 1, 2023
@typescript-bot
Copy link
Contributor

@froissant: Everything looks good here. I am ready to merge this PR (at 0bc93f3) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board Aug 1, 2023
@froissant
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Aug 1, 2023
@typescript-bot typescript-bot merged commit 0238db4 into DefinitelyTyped:master Aug 1, 2023
3 checks passed
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainer Approved New Definition This PR creates a new definition package. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants