Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Improves Documentation of Alpine Methods #66890

Closed
wants to merge 2 commits into from

Conversation

ekwoka
Copy link
Contributor

@ekwoka ekwoka commented Oct 1, 2023

Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 1, 2023

@ekwoka Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Inactive

This PR has been inactive for 31 days — closed because it wasn't merged for a long time!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 66890,
  "author": "ekwoka",
  "headCommitOid": "4bc403cad223d7eb9f6f7d698f0d12fa7d04043c",
  "mergeBaseOid": "62e861498b0c5a98468c18624877a046ec9ae0b8",
  "lastPushDate": "2023-10-01T16:38:56.000Z",
  "lastActivityDate": "2023-10-02T19:45:41.000Z",
  "mergeOfferDate": "2023-10-02T19:46:24.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "alpinejs",
      "kind": "edit",
      "files": [
        {
          "path": "types/alpinejs/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "wtho",
        "ekwoka"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2023-10-02T19:45:41.000Z",
      "isMaintainer": true
    },
    {
      "type": "stale",
      "reviewer": "Semigradsky",
      "date": "2023-10-01T19:04:32.000Z",
      "abbrOid": "7bad3a3"
    }
  ],
  "mainBotCommentID": 1742134110,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Author is Owner The author of this PR is a listed owner of the package. Untested Change This PR does not touch tests labels Oct 1, 2023
@typescript-bot
Copy link
Contributor

Hey @ekwoka,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Oct 1, 2023
@typescript-bot
Copy link
Contributor

🔔 @wtho — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@ekwoka ekwoka changed the title alpinejs typos 📝 Improves Documentation of Alpine Methods Oct 1, 2023
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Oct 1, 2023
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Oct 1, 2023
@typescript-bot
Copy link
Contributor

@ekwoka The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

1 similar comment
@typescript-bot
Copy link
Contributor

@ekwoka The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

Copy link
Contributor

@Semigradsky Semigradsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why I see this PR in my notifications but LGTM!

@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Oct 1, 2023
@dygy
Copy link
Contributor

dygy commented Oct 1, 2023

I don't know why I see this PR in my notifications but LGTM!

same shit bro :DDDD

@ekwoka
Copy link
Contributor Author

ekwoka commented Oct 2, 2023

😆

I guess just from having recent commits somehow the bot/github messed up

Oh no, I realized I had accidentally made the pr with gh pr create -f and it somehow filled in info from the last 30 commits on main as the PR description before I edited it...

so people got tagged....

well, at least i didn't tag epic games

@typescript-bot typescript-bot removed Other Approved This PR was reviewed and signed-off by a community member. The CI failed When GH Actions fails labels Oct 2, 2023
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Oct 2, 2023
@typescript-bot
Copy link
Contributor

@Semigradsky Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Oct 2, 2023
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Oct 2, 2023
@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 2, 2023

@ekwoka: Everything looks good here. I am ready to merge this PR (at 4bc403c) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@wtho: you can do this too.)

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board Oct 2, 2023
@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Oct 13, 2023
@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 13, 2023

Re-ping @ekwoka / @wtho:

This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Nov 1st (in three weeks) if this doesn't happen.

(If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.)

@typescript-bot typescript-bot added No Other Owners This DT module only has one owner, so we can't have someone verify the change. Author is Owner The author of this PR is a listed owner of the package. and removed Author is Owner The author of this PR is a listed owner of the package. No Other Owners This DT module only has one owner, so we can't have someone verify the change. labels Oct 18, 2023
@typescript-bot typescript-bot removed this from Waiting for Author to Merge in New Pull Request Status Board Nov 3, 2023
@typescript-bot
Copy link
Contributor

After a month, no one has requested merging the PR 😞. I'm going to assume that the change is not wanted after all, and will therefore close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner Unmerged The author did not merge the PR when it was ready. Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants