Allow for custom keys in TileLayerOptions #6694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to microsoft/TypeScript#3755, properties not previously defined in a type will now be marked as errors during compilation in TypeScript 1.6 and later. Since a TileLayerOptions object is dynamically evaluated for custom properties that might be used in a provided tile URL template, the TypeScript change breaks this functionality. The proposed change adds a string indexer (one of the suggested changes in the link above), which fixes the issue.
|
leaflet/leaflet.d.ts to author(@rgripper). could you review this PR? check list
|
|
@dt-bot 👍 |
basarat
added a commit
that referenced
this pull request
Nov 15, 2015
Allow for custom keys in TileLayerOptions
|
@vvakame your DT bot is AWESOME! 🌹 |
|
@basarat oh that's the reason the bot seemed so familiar xD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to microsoft/TypeScript#3755, properties not previously defined in a type will now be marked as errors during compilation in TypeScript 1.6 and later.
Since a TileLayerOptions object is dynamically evaluated for custom properties that might be used in a provided tile URL template, the TypeScript change breaks this functionality.
The proposed change adds a string indexer (one of the suggested changes in the link above), which fixes the issue.