node: add types for the new Date mocks in the upcoming version

[khaosdoctor]

This PR adds the types for Date mocks coming in the next minor release of Node. I'm attaching the original PR.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: test_runner: Add Date to the supported mock APIs nodejs/node#48638
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[khaosdoctor]

Version is still unknown since it wasn't released yet. As soon as it's released I'll update with the node version number

[khaosdoctor]

This change is coming in the next version, so if you want to wait until the merge

[typescript-bot]

@khaosdoctor Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• node — on npm, on unpkg
  • owner-approval: @peterblazejewicz, @Semigradsky

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 67035,
  "author": "khaosdoctor",
  "headCommitOid": "099f0eecd96f383e14269192cce9e70f9a3327f8",
  "mergeBaseOid": "15024fd054cd63fa11739f178a166d7c836b248e",
  "lastPushDate": "2023-10-12T01:06:51.000Z",
  "lastActivityDate": "2024-01-17T06:22:02.000Z",
  "mergeOfferDate": "2024-01-16T20:47:57.000Z",
  "mergeRequestDate": "2024-01-17T06:22:02.000Z",
  "mergeRequestUser": "Semigradsky",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/test.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/test/test.ts",
          "kind": "test"
        },
        {
          "path": "types/node/ts4.8/test.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/ts4.8/test/test.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Microsoft",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "n-e",
        "galkin",
        "parambirs",
        "eps1lon",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "ZYSzys",
        "NodeJS",
        "LinusU",
        "wafuwafu13",
        "mcollina",
        "Semigradsky"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2024-01-16T20:47:16.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "Semigradsky",
      "date": "2024-01-13T15:41:44.000Z",
      "isMaintainer": false
    },
    {
      "type": "stale",
      "reviewer": "sheetalkamat",
      "date": "2023-10-30T21:41:26.000Z",
      "abbrOid": "41eba7f"
    }
  ],
  "mainBotCommentID": 1763034642,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[peterblazejewicz]

Please convert to draft (to save CPU/planet)

coming in the next minor release of Node

[khaosdoctor]

@peterblazejewicz sure thing

[khaosdoctor]

This was merged :)

[typescript-bot]

Re-ping @microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[typescript-bot]

Re-ping @microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[Semigradsky]

Need a wait for a new Node.js 20.x release with this change.

[Semigradsky]

Please make the same changes in types/node/ts4.8 folder (for users who use TypeScript <= 4.8)

[typescript-bot]

@khaosdoctor One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

[Semigradsky]

@khaosdoctor Will you open new? I thought you will rebase from master this PR

[khaosdoctor]

From what I've seen they have already added the types for the mocks in the review 🧐 didn't they?

[Semigradsky]

I have only updated doc comments

[khaosdoctor]

Oh sorry I didn't see it! Reopened, will fix the conflicts and open to be ready for review!

[khaosdoctor]

@Semigradsky ready for review!

[typescript-bot]

@sheetalkamat Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[Semigradsky]

@peterblazejewicz please take a look 🙏

[peterblazejewicz]

@khaosdoctor thx!
sorry it went under the radar 🙇🏻

[Semigradsky]

Ready to merge

[khaosdoctor]

Yay! Thanks peeps