node: add types for the new Date mocks in the upcoming version

[khaosdoctor]

This PR adds the types for Date mocks coming in the next minor release of Node. I'm attaching the original PR.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: test_runner: Add Date to the supported mock APIs nodejs/node#48638
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[khaosdoctor]

Version is still unknown since it wasn't released yet. As soon as it's released I'll update with the node version number

[khaosdoctor]

This change is coming in the next version, so if you want to wait until the merge

[typescript-bot]

@khaosdoctor Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• node — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 67035,
  "author": "khaosdoctor",
  "headCommitOid": "41eba7f898929e70ef79163f6b2752e4595f150c",
  "mergeBaseOid": "a95a9d92473b8b8bcf8317c3df1ddf37b5c608c4",
  "lastPushDate": "2023-10-12T01:06:51.000Z",
  "lastActivityDate": "2023-12-14T04:12:34.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/test.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/test/test.ts",
          "kind": "test"
        },
        {
          "path": "types/node/ts4.8/test.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/ts4.8/test/test.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Microsoft",
        "DefinitelyTyped",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "n-e",
        "galkin",
        "parambirs",
        "eps1lon",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "ZYSzys",
        "NodeJS",
        "LinusU",
        "wafuwafu13",
        "mcollina",
        "Semigradsky"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "Semigradsky",
      "date": "2023-10-31T08:19:20.000Z"
    },
    {
      "type": "approved",
      "reviewer": "sheetalkamat",
      "date": "2023-10-30T21:41:26.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1763034642,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[peterblazejewicz]

Please convert to draft (to save CPU/planet)

coming in the next minor release of Node

[khaosdoctor]

@peterblazejewicz sure thing

[khaosdoctor]

This was merged :)

[typescript-bot]

Re-ping @microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[typescript-bot]

Re-ping @microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[Semigradsky]

Need a wait for a new Node.js 20.x release with this change.

[Semigradsky]

Please make the same changes in types/node/ts4.8 folder (for users who use TypeScript <= 4.8)

[typescript-bot]

@khaosdoctor One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

[typescript-bot]

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @khaosdoctor.

(Ping @microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky.)

[Semigradsky]

Need a wait for a new Node.js 20.x release with this change.

[typescript-bot]

@khaosdoctor One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

[khaosdoctor]

New version has been launched with the change: https://nodejs.org/en/blog/release/v21.2.0

[khaosdoctor]

@Semigradsky I think it's safe to merge now

[jakebailey]

That's v21, but the types are v20. My understanding is that DT doesn't ever contain the odd numbered versions, so this has to wait for a backport to v20 or v18.

[khaosdoctor]

That's v21, but the types are v20. My understanding is that DT doesn't ever contain the odd numbered versions, so this has to wait for a backport to v20 or v18.

But then if someone wants to use it on a current version this is then not defined? Like, if I wanted to install and use Node 21.2, especially for testing this feature for example, shouldn't we have the types for it as well?

[jakebailey]

Well, there was actually a v13, v15, and v17, but no v19 and so far no v21. So my blanket statement was not correct historically. Sorry about that.

In any case it's up to the node types maintainers to decide if they want to deal with yet another version in the types.

But, it still hasn't been done in years, it seems.

[typescript-bot]

@khaosdoctor I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Dec 17th (in a week) if the issues aren't addressed.

[khaosdoctor]

Can I reopen this once we have a new release?

[Semigradsky]

You can mark as draft. Draft shouldn't be closed

[khaosdoctor]

Nice, I'm drafting it then until the Node team launches the next stable