Update string.prototype.matchall for TS 5.4

[sandersn]

matchAll actually returns RegExpExecArray not RegExpMatchArray -- index and input are not optional. TS 5.4 just fixed this, so string.prototype.matchall needs an update too.

Caused by microsoft/TypeScript#55565

[typescript-bot]

@sandersn Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• string.prototype.matchall — on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 67760,
  "author": "sandersn",
  "headCommitOid": "493485797ae9a170fd96f0f14a578db0b1e0fca5",
  "mergeBaseOid": "4315b7f96b27ef6a8ba845d8d8808124bae142ce",
  "lastPushDate": "2023-12-04T14:59:08.000Z",
  "lastActivityDate": "2023-12-04T14:59:08.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "string.prototype.matchall",
      "kind": "edit",
      "files": [
        {
          "path": "types/string.prototype.matchall/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/string.prototype.matchall/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/string.prototype.matchall/string.prototype.matchall-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1838826557,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.