New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update types for yauzl-promise to add AsyncIterable support #68387
Update types for yauzl-promise to add AsyncIterable support #68387
Conversation
@EvanHahn Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 68387,
"author": "EvanHahn",
"headCommitOid": "b69fe77a9a7f786a0e430f20fd6f22d1393a5cf6",
"mergeBaseOid": "f3f9defe4c1e3b96a1c839c18170d7513cae5006",
"lastPushDate": "2024-01-30T20:04:13.000Z",
"lastActivityDate": "2024-02-04T14:43:18.000Z",
"mergeOfferDate": "2024-02-04T14:37:09.000Z",
"mergeRequestDate": "2024-02-04T14:43:18.000Z",
"mergeRequestUser": "EvanHahn",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "yauzl-promise",
"kind": "edit",
"files": [
{
"path": "types/yauzl-promise/index.d.ts",
"kind": "definition"
},
{
"path": "types/yauzl-promise/yauzl-promise-tests.ts",
"kind": "test"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2024-02-04T14:36:28.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1917799056,
"ciResult": "pass"
} |
🔔 @EvanHahn — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
👋 I just made some fairly big changes to DefinitelyTyped CI infrastructure. This is the newest PR at the moment but CI ran before my changes, so I’m going to close and reopen to retrigger CI and make sure I didn’t completely break everything. Sorry for the noise! |
@EvanHahn: Everything looks good here. I am ready to merge this PR (at b69fe77) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
Ready to merge |
Please fill in this template.
pnpm test yauzl-promise
.Select one of these and delete the others:
If changing an existing definition:
If this PR brings the type definitions up to date with a new version of the JS library, update the version number in thepackage.json
.