Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types for yauzl-promise to add AsyncIterable support #68387

Merged

Conversation

EvanHahn
Copy link
Contributor

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 30, 2024

@EvanHahn Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 68387,
  "author": "EvanHahn",
  "headCommitOid": "b69fe77a9a7f786a0e430f20fd6f22d1393a5cf6",
  "mergeBaseOid": "f3f9defe4c1e3b96a1c839c18170d7513cae5006",
  "lastPushDate": "2024-01-30T20:04:13.000Z",
  "lastActivityDate": "2024-02-04T14:43:18.000Z",
  "mergeOfferDate": "2024-02-04T14:37:09.000Z",
  "mergeRequestDate": "2024-02-04T14:43:18.000Z",
  "mergeRequestUser": "EvanHahn",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "yauzl-promise",
      "kind": "edit",
      "files": [
        {
          "path": "types/yauzl-promise/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/yauzl-promise/yauzl-promise-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2024-02-04T14:36:28.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1917799056,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the No Other Owners This DT module only has one owner, so we can't have someone verify the change. label Jan 30, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Jan 30, 2024
@typescript-bot
Copy link
Contributor

🔔 @EvanHahn — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@andrewbranch
Copy link
Member

👋 I just made some fairly big changes to DefinitelyTyped CI infrastructure. This is the newest PR at the moment but CI ran before my changes, so I’m going to close and reopen to retrigger CI and make sure I didn’t completely break everything. Sorry for the noise!

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Feb 4, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board Feb 4, 2024
@typescript-bot
Copy link
Contributor

@EvanHahn: Everything looks good here. I am ready to merge this PR (at b69fe77) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@EvanHahn
Copy link
Contributor Author

EvanHahn commented Feb 4, 2024

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Feb 4, 2024
@typescript-bot typescript-bot merged commit 363c984 into DefinitelyTyped:master Feb 4, 2024
5 checks passed
@EvanHahn EvanHahn deleted the yauzl-promise-async-iterable branch February 4, 2024 14:44
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainer Approved No Other Owners This DT module only has one owner, so we can't have someone verify the change. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants