-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@types/firefox-webext-browser] #68241 fix type for browser.runtime.Port.postMessage
argument
#68468
Conversation
@Grayson-code Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. InactiveThis PR has been inactive for 18 days — please merge or say something if there's a problem, otherwise it will be closed! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 68468,
"author": "Grayson-code",
"headCommitOid": "9ec7ed43c882f66d4486d45a5ac42925b0bca323",
"mergeBaseOid": "6b8c21b743fa1ee072d98b3b88ded58da9f71d0a",
"lastPushDate": "2024-02-04T13:54:26.000Z",
"lastActivityDate": "2024-03-10T17:07:45.000Z",
"mergeOfferDate": "2024-02-21T16:07:34.000Z",
"mergeRequestDate": "2024-03-10T17:07:45.000Z",
"mergeRequestUser": "Grayson-code",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "firefox-webext-browser",
"kind": "edit",
"files": [
{
"path": "types/firefox-webext-browser/index.d.ts",
"kind": "definition"
}
],
"owners": [
"jsmnbom"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "codershiba",
"date": "2024-02-26T10:36:10.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "rbuckton",
"date": "2024-02-21T16:06:51.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1925758773,
"ciResult": "pass"
} |
Hey @Grayson-code, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
🔔 @jsmnbom — please review this PR in the next few days. Be sure to explicitly select |
Re-ping @jsmnbom: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
@Grayson-code: Everything looks good here. I am ready to merge this PR (at 9ec7ed4) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@jsmnbom: you can do this too.) |
Re-ping @Grayson-code / @jsmnbom: This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Mar 22nd (in three weeks) if this doesn't happen. (If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.) |
Ready to merge |
Please fill in this template.
pnpm test <package to test>
.If changing an existing definition:
package.json
.