Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add magika types #68765

Merged
merged 6 commits into from
Feb 29, 2024

Conversation

glassonion1
Copy link
Contributor

@glassonion1 glassonion1 commented Feb 26, 2024

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 26, 2024

@glassonion1 Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes when there are new packages added

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 68765,
  "author": "glassonion1",
  "headCommitOid": "88df91c91a690b5ddaea2d102b467e6a10e6409a",
  "mergeBaseOid": "199565841e7fe9ccfb67e52fb4773b840e3d28a4",
  "lastPushDate": "2024-02-26T10:54:42.000Z",
  "lastActivityDate": "2024-02-29T23:56:18.000Z",
  "mergeOfferDate": "2024-02-29T23:53:25.000Z",
  "mergeRequestDate": "2024-02-29T23:56:18.000Z",
  "mergeRequestUser": "glassonion1",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "magika",
      "kind": "add",
      "files": [
        {
          "path": "types/magika/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/magika/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/magika/magika-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/magika/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/magika/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "glassonion1"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2024-02-29T23:53:17.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1963850591,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. Check Config Changes a module config files labels Feb 26, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Feb 26, 2024
@typescript-bot
Copy link
Contributor

🔔 @glassonion1 — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Feb 26, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Feb 26, 2024
@typescript-bot
Copy link
Contributor

@glassonion1 The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Feb 26, 2024
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Feb 26, 2024
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Feb 26, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Feb 26, 2024
@typescript-bot
Copy link
Contributor

@glassonion1 The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed The CI failed When GH Actions fails Check Config Changes a module config files labels Feb 26, 2024
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Feb 26, 2024
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Feb 26, 2024
@typescript-bot
Copy link
Contributor

@glassonion1 The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Feb 26, 2024
@jakebailey
Copy link
Member

This failure is strange; it's not clear to me that there's a problem with the types as-is here. @andrewbranch if the upstream module doesn't do CJS at all, what can be done to make a PR like this pass?

@typescript-bot typescript-bot removed this from Needs Author Action in New Pull Request Status Board Feb 29, 2024
@andrewbranch andrewbranch reopened this Feb 29, 2024
@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Feb 29, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Feb 29, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Feb 29, 2024
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Feb 29, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board Feb 29, 2024
@typescript-bot typescript-bot removed Self Merge This PR can now be self-merged by the PR author or an owner Maintainer Approved labels Feb 29, 2024
@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Waiting for Code Reviews in New Pull Request Status Board Feb 29, 2024
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Feb 29, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board Feb 29, 2024
@glassonion1
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Feb 29, 2024
@typescript-bot typescript-bot merged commit 72bce2c into DefinitelyTyped:master Feb 29, 2024
4 checks passed
@glassonion1
Copy link
Contributor Author

@jakebailey
Thanks for your review, and thanks to the PR below, I was able to pass the test.

#68846

@glassonion1 glassonion1 deleted the feature/add_magika branch February 29, 2024 23:59
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainer Approved New Definition This PR creates a new definition package. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants