-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add magika types #68765
feat: add magika types #68765
Conversation
@glassonion1 Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 68765,
"author": "glassonion1",
"headCommitOid": "88df91c91a690b5ddaea2d102b467e6a10e6409a",
"mergeBaseOid": "199565841e7fe9ccfb67e52fb4773b840e3d28a4",
"lastPushDate": "2024-02-26T10:54:42.000Z",
"lastActivityDate": "2024-02-29T23:56:18.000Z",
"mergeOfferDate": "2024-02-29T23:53:25.000Z",
"mergeRequestDate": "2024-02-29T23:56:18.000Z",
"mergeRequestUser": "glassonion1",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "magika",
"kind": "add",
"files": [
{
"path": "types/magika/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/magika/index.d.ts",
"kind": "definition"
},
{
"path": "types/magika/magika-tests.ts",
"kind": "test"
},
{
"path": "types/magika/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/magika/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"glassonion1"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2024-02-29T23:53:17.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1963850591,
"ciResult": "pass"
} |
🔔 @glassonion1 — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
@glassonion1 The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
@glassonion1 The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
@glassonion1 The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
This failure is strange; it's not clear to me that there's a problem with the types as-is here. @andrewbranch if the upstream module doesn't do CJS at all, what can be done to make a PR like this pass? |
Ready to merge |
@jakebailey |
Please fill in this template.
pnpm test <package to test>
.Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.