Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[readable-stream] remove deprecated tag from Duplex.from #69164

Conversation

10xLaCroixDrinker
Copy link
Contributor

@10xLaCroixDrinker 10xLaCroixDrinker commented Mar 25, 2024

Select one of these and delete the others:

If changing an existing definition:

These were marked deprecated/never because readable-stream did not support them, but they've had parity with Node 18 since 4.0.0

Related nodejs/readable-stream#534

  • Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 25, 2024

@10xLaCroixDrinker Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69164,
  "author": "10xLaCroixDrinker",
  "headCommitOid": "6e8fd65163d9ee1e425c72f77205d97ecfcca848",
  "mergeBaseOid": "f28fbd97b9fea22e6174db17652d91a94eb2006a",
  "lastPushDate": "2024-03-25T16:03:57.000Z",
  "lastActivityDate": "2024-05-02T20:23:34.000Z",
  "maintainerBlessed": "Waiting for Code Reviews",
  "mergeOfferDate": "2024-05-02T20:10:35.000Z",
  "mergeRequestDate": "2024-05-02T20:23:34.000Z",
  "mergeRequestUser": "10xLaCroixDrinker",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "readable-stream",
      "kind": "edit",
      "files": [
        {
          "path": "types/readable-stream/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/readable-stream/readable-stream-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "TeamworkGuy2",
        "markdreyer"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2024-05-02T20:09:54.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2018359051,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Mar 25, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Mar 25, 2024
@typescript-bot
Copy link
Contributor

🔔 @TeamworkGuy2 @markdreyer — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Apr 5, 2024
@typescript-bot
Copy link
Contributor

Re-ping @TeamworkGuy2, @markdreyer:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Apr 12, 2024
@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @10xLaCroixDrinker.

(Ping @TeamworkGuy2, @markdreyer.)

@andrewbranch andrewbranch moved this from Needs Maintainer Action to Waiting for Code Reviews in New Pull Request Status Board Apr 16, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Apr 16, 2024
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels May 2, 2024
@typescript-bot
Copy link
Contributor

@10xLaCroixDrinker: Everything looks good here. I am ready to merge this PR (at 6e8fd65) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@TeamworkGuy2, @markdreyer: you can do this too.)

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board May 2, 2024
@10xLaCroixDrinker
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board May 2, 2024
@typescript-bot typescript-bot merged commit 1243e1a into DefinitelyTyped:master May 2, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainer Approved Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants