-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@types/tar] Add preservePaths
to ExtractOptions
#69215
base: master
Are you sure you want to change the base?
Conversation
@codershiba Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69215,
"author": "codershiba",
"headCommitOid": "b0eeeb44e50e0367df0367020af71e06655dc130",
"mergeBaseOid": "d1c86a69d0922a7fbccc532e0e0cc87d351cc118",
"lastPushDate": "2024-03-30T17:52:48.000Z",
"lastActivityDate": "2024-04-23T05:48:32.000Z",
"hasMergeConflict": true,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "tar",
"kind": "edit",
"files": [
{
"path": "types/tar/index.d.ts",
"kind": "definition"
},
{
"path": "types/tar/tar-tests.ts",
"kind": "test"
}
],
"owners": [
"SomaticIT",
"connor4312"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "kanmao",
"date": "2024-04-23T05:48:32.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "MysteryBlokHed",
"date": "2024-03-30T18:10:00.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 2028381966,
"ciResult": "pass"
} |
🔔 @SomaticIT @connor4312 — please review this PR in the next few days. Be sure to explicitly select |
@codershiba Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69215,
"author": "codershiba",
"headCommitOid": "b0eeeb44e50e0367df0367020af71e06655dc130",
"mergeBaseOid": "d1c86a69d0922a7fbccc532e0e0cc87d351cc118",
"lastPushDate": "2024-03-30T17:52:48.000Z",
"lastActivityDate": "2024-04-23T05:48:32.000Z",
"hasMergeConflict": true,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "tar",
"kind": "edit",
"files": [
{
"path": "types/tar/index.d.ts",
"kind": "definition"
},
{
"path": "types/tar/tar-tests.ts",
"kind": "test"
}
],
"owners": [
"SomaticIT",
"connor4312"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "kanmao",
"date": "2024-04-23T05:48:32.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "MysteryBlokHed",
"date": "2024-03-30T18:10:00.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 2028381966,
"ciResult": "pass"
} |
🔔 @SomaticIT @connor4312 — please review this PR in the next few days. Be sure to explicitly select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating the tests (tar-tests.ts) will allow this to get merged sooner. Something like:
tar.x({ preservePaths: true });
@MysteryBlokHed Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM—just needs a package owner's approval
@codershiba Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day! |
@codershiba I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Apr 29th (in a week) if the issues aren't addressed. |
Please fill in this template.
pnpm test tar
.If changing an existing definition:
package.json
.