Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/tar] Add preservePaths to ExtractOptions #69215

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

codershiba
Copy link
Contributor

@codershiba codershiba commented Mar 30, 2024

Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@typescript-bot typescript-bot added this to Needs Author Action in New Pull Request Status Board Mar 30, 2024
@codershiba codershiba marked this pull request as ready for review March 30, 2024 17:53
@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 30, 2024

@codershiba Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ❌ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69215,
  "author": "codershiba",
  "headCommitOid": "b0eeeb44e50e0367df0367020af71e06655dc130",
  "mergeBaseOid": "d1c86a69d0922a7fbccc532e0e0cc87d351cc118",
  "lastPushDate": "2024-03-30T17:52:48.000Z",
  "lastActivityDate": "2024-04-23T05:48:32.000Z",
  "hasMergeConflict": true,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "tar",
      "kind": "edit",
      "files": [
        {
          "path": "types/tar/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/tar/tar-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "SomaticIT",
        "connor4312"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "kanmao",
      "date": "2024-04-23T05:48:32.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "MysteryBlokHed",
      "date": "2024-03-30T18:10:00.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2028381966,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels Mar 30, 2024
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Mar 30, 2024
@typescript-bot
Copy link
Contributor

🔔 @SomaticIT @connor4312 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 30, 2024

@codershiba Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ❌ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69215,
  "author": "codershiba",
  "headCommitOid": "b0eeeb44e50e0367df0367020af71e06655dc130",
  "mergeBaseOid": "d1c86a69d0922a7fbccc532e0e0cc87d351cc118",
  "lastPushDate": "2024-03-30T17:52:48.000Z",
  "lastActivityDate": "2024-04-23T05:48:32.000Z",
  "hasMergeConflict": true,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "tar",
      "kind": "edit",
      "files": [
        {
          "path": "types/tar/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/tar/tar-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "SomaticIT",
        "connor4312"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "kanmao",
      "date": "2024-04-23T05:48:32.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "MysteryBlokHed",
      "date": "2024-03-30T18:10:00.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2028381966,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @SomaticIT @connor4312 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Copy link
Contributor

@MysteryBlokHed MysteryBlokHed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the tests (tar-tests.ts) will allow this to get merged sooner. Something like:

tar.x({ preservePaths: true });

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Mar 30, 2024
@typescript-bot typescript-bot removed the Untested Change This PR does not touch tests label Mar 30, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Mar 30, 2024
@typescript-bot
Copy link
Contributor

@MysteryBlokHed Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

Copy link
Contributor

@MysteryBlokHed MysteryBlokHed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM—just needs a package owner's approval

@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. labels Mar 30, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Apr 4, 2024
@typescript-bot
Copy link
Contributor

@codershiba Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

@typescript-bot typescript-bot added the Abandoned This PR had no activity for a long time, and is considered abandoned label Apr 22, 2024
@typescript-bot
Copy link
Contributor

@codershiba I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Apr 29th (in a week) if the issues aren't addressed.

@typescript-bot typescript-bot removed the Abandoned This PR had no activity for a long time, and is considered abandoned label Apr 23, 2024
@codershiba codershiba marked this pull request as draft April 25, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. Other Approved This PR was reviewed and signed-off by a community member. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants