feat: Added support for jsonl-db #69317

FleetAdmiralJakob · 2024-04-09T18:05:57Z

Please fill in this template.

Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from the readme.
Avoid common mistakes.
Run pnpm test <package to test>.

Select one of these and delete the others:

If adding a new definition:

The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
Create it with dts-gen --dt, not by basing it on an existing project.
Represents shape of module/library correctly
tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

Provide a URL to documentation or source code which provides context for the suggested changes: <>
If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
Delete the package's directory.
Add it to notNeededPackages.json.

typescript-bot · 2024-04-09T18:06:36Z

@FleetAdmiralJakob Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

jsonl-db (new!) — on npm, on unpkg
- 1 added owner: ✎@FleetAdmiralJakob

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
❌ Continuous integration tests have failed
🕐 Only a DT maintainer can approve changes when there are new packages added

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 31 days — it is considered abandoned, and therefore closed!

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 69317,
  "author": "FleetAdmiralJakob",
  "headCommitOid": "fd70b287315d300b98d344cb8ad677956fdf94f1",
  "mergeBaseOid": "07c771f1e113e2ebcd6a88778555883f22166ab3",
  "lastPushDate": "2024-04-09T18:05:57.000Z",
  "lastActivityDate": "2024-04-09T18:05:57.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "jsonl-db",
      "kind": "add",
      "files": [
        {
          "path": "types/jsonl-db/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/jsonl-db/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/jsonl-db/jsonl-db-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/jsonl-db/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/jsonl-db/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "FleetAdmiralJakob"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 2045806035,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/fd70b287315d300b98d344cb8ad677956fdf94f1/checks?check_suite_id=22589703444"
}

typescript-bot · 2024-04-09T18:06:38Z

🔔 @FleetAdmiralJakob — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

typescript-bot · 2024-04-09T18:09:02Z

@FleetAdmiralJakob The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!