knuddels-userapp-backend-api - deprecated KnuddelAccount and KnuddelPot

[SirezKN]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run pnpm test <package to test>.

Select one of these and delete the others:

If adding a new definition:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: <>
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

[typescript-bot]

@SirezKN Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• knuddels-userapp-backend-api — on npm, on unpkg

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 69361,
  "author": "SirezKN",
  "headCommitOid": "544ed816dd00955d7e6336b9eb9421b9c3fc969a",
  "mergeBaseOid": "c54e64842705dc21966e80ecff03bf1a158351ef",
  "lastPushDate": "2024-04-15T13:33:07.000Z",
  "lastActivityDate": "2024-05-28T20:28:37.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "knuddels-userapp-backend-api",
      "kind": "edit",
      "files": [
        {
          "path": "types/knuddels-userapp-backend-api/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/knuddels-userapp-backend-api/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Knuddels"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "sheetalkamat",
      "date": "2024-05-28T20:28:37.000Z"
    }
  ],
  "mainBotCommentID": 2056871265,
  "ciResult": "pass"
}

[typescript-bot]

Hey @SirezKN,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

[typescript-bot]

🔔 @Knuddels — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@SirezKN Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

[SirezKN]

Looks fine to me

[typescript-bot]

@SirezKN The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

@SirezKN The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[SirezKN]

Formatting

The following files are not formatted:

1. types/knuddels-userapp-backend-api/index.d.ts

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against 5222a5a

the command doesn't change the format

[typescript-bot]

Re-ping @Knuddels:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[typescript-bot]

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @SirezKN.

(Ping @Knuddels.)

[jakebailey]

That's a lot of formatting changes; I'm not sure how we can validate this when there's so much noise and without any documentation.

[sandersn]

I would be OK with taking this change if somebody from Knuddels would be able to review it. @SirezKN, your branch came from the Knuddels fork. Are you affiliated with them?

[sheetalkamat]

Need original author/organization approval

[typescript-bot]

@SirezKN One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!