Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/selectize] Add types for missing methods #69378

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codershiba
Copy link
Contributor

@codershiba codershiba commented Apr 17, 2024

Closes #69336
Closes #69377

Please fill in this template.

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 17, 2024

@codershiba Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 28 days — it is still unreviewed!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69378,
  "author": "codershiba",
  "headCommitOid": "59b331efad11cce2f8ae114371cbdd4de1a8eb06",
  "mergeBaseOid": "895d2be48edd77037fb8920161d109059d600002",
  "lastPushDate": "2024-04-17T10:44:15.000Z",
  "lastActivityDate": "2024-05-06T17:17:14.000Z",
  "maintainerBlessed": "Waiting for Code Reviews",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "selectize",
      "kind": "edit",
      "files": [
        {
          "path": "types/selectize/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "adidahiya",
        "naBausch"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 2060967891,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels Apr 17, 2024
@typescript-bot
Copy link
Contributor

Hey @codershiba,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Apr 17, 2024
@typescript-bot
Copy link
Contributor

🔔 @adidahiya @naBausch — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Apr 17, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Apr 17, 2024
@typescript-bot
Copy link
Contributor

@codershiba The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Apr 17, 2024
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Apr 17, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Apr 17, 2024
@typescript-bot
Copy link
Contributor

Re-ping @adidahiya, @naBausch:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Apr 28, 2024
@iisaduan iisaduan moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Apr 29, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board May 5, 2024
@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @codershiba.

(Ping @adidahiya, @naBausch.)

@jakebailey
Copy link
Member

As in the other PR, DT is at 0.12, and this package upstream is at 0.15; can you verify which versions things were added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Popular package This PR affects a popular package (as counted by NPM download counts). Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. Untested Change This PR does not touch tests
Projects
New Pull Request Status Board
Needs Maintainer Action
Development

Successfully merging this pull request may close these issues.

@types/selectize : Missing methods clearOptionGroups, removeOptionGroup and addItems
3 participants