Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/hubot] Update the declaration for users() to bring it up to date for Hubot v11 #69394

Merged

Conversation

yincrash
Copy link
Contributor

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

This matches what actually gets returned in the Hubot project
@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 19, 2024

@yincrash Thank you for submitting this PR!

This is a live comment which I will keep updated.

2 packages in this PR

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes which affect more than one package

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69394,
  "author": "yincrash",
  "headCommitOid": "671fbe346a6b0540df3a772b4b48a2af134e0d04",
  "mergeBaseOid": "9ff6856db12ba15015b91b2466171b7f27ab3677",
  "lastPushDate": "2024-04-19T03:32:34.000Z",
  "lastActivityDate": "2024-05-01T22:02:32.000Z",
  "mergeOfferDate": "2024-05-01T21:44:04.000Z",
  "mergeRequestDate": "2024-05-01T22:02:32.000Z",
  "mergeRequestUser": "yincrash",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "hubot-slack",
      "kind": "edit",
      "files": [
        {
          "path": "types/hubot-slack/hubot-extension.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/hubot-slack/hubot-slack-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/hubot-slack/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/hubot-slack/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "hubot",
      "kind": "edit",
      "files": [
        {
          "path": "types/hubot/hubot-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/hubot/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/hubot/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "dirk",
        "KeesCBakker",
        "eeemil",
        "jphenow"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2024-05-01T21:43:23.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2065686357,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Apr 19, 2024
@typescript-bot
Copy link
Contributor

🔔 @dirk @KeesCBakker @Eeemil @jphenow — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Apr 19, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Apr 19, 2024
@typescript-bot
Copy link
Contributor

@yincrash The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@yincrash
Copy link
Contributor Author

Ah looks like it affects hubot-slack tests and so I need to update that package as well.

@typescript-bot typescript-bot added Edits multiple packages and removed The CI failed When GH Actions fails labels Apr 19, 2024
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Apr 19, 2024
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Apr 19, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Apr 19, 2024
@typescript-bot
Copy link
Contributor

@yincrash The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Apr 19, 2024
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Apr 19, 2024
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Apr 19, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Apr 19, 2024
@typescript-bot
Copy link
Contributor

@yincrash The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Apr 19, 2024
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Apr 19, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Apr 19, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Apr 19, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Apr 19, 2024
@typescript-bot
Copy link
Contributor

Re-ping @dirk, @KeesCBakker, @Eeemil, @jphenow:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Apr 30, 2024
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels May 1, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board May 1, 2024
@typescript-bot
Copy link
Contributor

@yincrash: Everything looks good here. I am ready to merge this PR (at 671fbe3) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@yincrash
Copy link
Contributor Author

yincrash commented May 1, 2024

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board May 1, 2024
@typescript-bot typescript-bot merged commit c72e7dd into DefinitelyTyped:master May 1, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board May 2, 2024
@yincrash yincrash deleted the yincrash/hubot-users branch May 8, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits multiple packages Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants