New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@types/hubot] Update the declaration for users() to bring it up to date for Hubot v11 #69394
[@types/hubot] Update the declaration for users() to bring it up to date for Hubot v11 #69394
Conversation
This matches what actually gets returned in the Hubot project
@yincrash Thank you for submitting this PR! This is a live comment which I will keep updated. 2 packages in this PRCode ReviewsBecause this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69394,
"author": "yincrash",
"headCommitOid": "671fbe346a6b0540df3a772b4b48a2af134e0d04",
"mergeBaseOid": "9ff6856db12ba15015b91b2466171b7f27ab3677",
"lastPushDate": "2024-04-19T03:32:34.000Z",
"lastActivityDate": "2024-05-01T22:02:32.000Z",
"mergeOfferDate": "2024-05-01T21:44:04.000Z",
"mergeRequestDate": "2024-05-01T22:02:32.000Z",
"mergeRequestUser": "yincrash",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "hubot-slack",
"kind": "edit",
"files": [
{
"path": "types/hubot-slack/hubot-extension.d.ts",
"kind": "definition"
},
{
"path": "types/hubot-slack/hubot-slack-tests.ts",
"kind": "test"
},
{
"path": "types/hubot-slack/index.d.ts",
"kind": "definition"
},
{
"path": "types/hubot-slack/package.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "hubot",
"kind": "edit",
"files": [
{
"path": "types/hubot/hubot-tests.ts",
"kind": "test"
},
{
"path": "types/hubot/index.d.ts",
"kind": "definition"
},
{
"path": "types/hubot/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"dirk",
"KeesCBakker",
"eeemil",
"jphenow"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "rbuckton",
"date": "2024-05-01T21:43:23.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2065686357,
"ciResult": "pass"
} |
🔔 @dirk @KeesCBakker @Eeemil @jphenow — please review this PR in the next few days. Be sure to explicitly select |
@yincrash The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
Ah looks like it affects |
@yincrash The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
@yincrash The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
Re-ping @dirk, @KeesCBakker, @Eeemil, @jphenow: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
@yincrash: Everything looks good here. I am ready to merge this PR (at 671fbe3) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
Ready to merge |
Please fill in this template.
pnpm test <package to test>
.Select one of these and delete the others:
If changing an existing definition:
Brain.users()
claims it returns an Array but returns an Object hubotio/hubot#1724package.json
.