fix: 68883 - BindDefinition to support DbType fix

[dannyb648]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run pnpm test <package to test>.

Select one of these and delete the others:

If adding a new definition:

• The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
• If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
• Create it with dts-gen --dt, not by basing it on an existing project.
• Represents shape of module/library correctly
• tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: <>
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

• If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
• Delete the package's directory.
• Add it to notNeededPackages.json.

[typescript-bot]

@dannyb648 Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• oracledb — on npm, on unpkg (author is owner)
  • owner-approval: @connorjayfitzgerald

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Inactive

This PR has been inactive for 14 days — please merge or say something if there's a problem, otherwise it will be closed!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 69402,
  "author": "dannyb648",
  "headCommitOid": "3180e5b7cde23b99f5b5a5c63664fffc95c04374",
  "mergeBaseOid": "ada5856a4c132e4d4494a607db68ea5535db07ee",
  "lastPushDate": "2024-04-20T07:41:49.000Z",
  "lastActivityDate": "2024-05-10T14:17:22.000Z",
  "mergeOfferDate": "2024-05-01T21:59:30.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "oracledb",
      "kind": "edit",
      "files": [
        {
          "path": "types/oracledb/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "connorjayfitzgerald",
        "dannyb648",
        "jacobwheale"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2024-05-01T21:58:46.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "dhrumit9",
      "date": "2024-04-20T08:54:30.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "connorjayfitzgerald",
      "date": "2024-04-20T08:51:48.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2067592745,
  "ciResult": "pass"
}

[typescript-bot]

Hey @dannyb648,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

[typescript-bot]

🔔 @connorjayfitzgerald @jacobwheale — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[dhrumit9]

I think at line 2226 for the interface Lob the read-only type should also be of DBType | number

[dhrumit9]

Similarly at line 2314 for Metadata interface fetchType property

[dhrumit9]

For Advance Queue
ln 2969 payloadType

For BaseDBObject
ln 3087 attributes.type
ln 3095 readonly elementType

[dannyb648]

Added those now @dhrumit9 - should patch all those youve mentioned - I really appreciate those spots, thanks!

[typescript-bot]

@connorjayfitzgerald Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[dhrumit9]

Hey @dannyb648, @connorjayfitzgerald, what is the expected timeline for this to be merged/released?

[RDIL]

@dhrumit9 it's waiting review from a DT maintainer, so probably some time in the next few days.

[typescript-bot]

⏳ Hi @dannyb648,

It's been a few days since this PR was approved by rbuckton, dhrumit9, connorjayfitzgerald and we're waiting for a DT maintainer to give a review.

If you would like to short-circuit this wait, you can edit some of the test files in the package which verify how the .d.ts files work. This would allow the PR to be merged by you or the DT module owners after a re-review.

[typescript-bot]

Re-ping @jacobwheale:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[typescript-bot]

@dannyb648: Everything looks good here. I am ready to merge this PR (at 3180e5b) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@connorjayfitzgerald, @jacobwheale: you can do this too.)

[SudevAtST]

@dannyb648 can you please merge this?
It has been a while since our CI is broken due to this and we have to hold back to 6.2.0 which was last working version.

[SudevAtST]

@dannyb648 can you please merge this? It has been a while since our CI is broken due to this and we have to hold back to 6.2.0 which was last working version.

@connorjayfitzgerald @jacobwheale If @dannyb648 is unavailable, can you please help to get this merged?

[typescript-bot]

Re-ping @dannyb648 / @jacobwheale:

This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on May 31st (in three weeks) if this doesn't happen.

(If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.)