Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/screeps-arena]update to game's current typing lib version v1.0.6 (for v0.1.18 game) #69405

Merged

Conversation

AutumnSaury
Copy link
Contributor

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: ChangeLogs on Steam
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

added missing type info for some "complex" constants according to the document of the game
@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 20, 2024

@AutumnSaury Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69405,
  "author": "AutumnSaury",
  "headCommitOid": "dc0d53c2d7e84f6737ced4b6b40d2020bcd0dc4c",
  "mergeBaseOid": "37d70ca66abce5789684db705021e27aa00832f5",
  "lastPushDate": "2024-04-20T16:08:20.000Z",
  "lastActivityDate": "2024-04-29T13:01:58.000Z",
  "mergeOfferDate": "2024-04-29T12:46:53.000Z",
  "mergeRequestDate": "2024-04-29T13:01:58.000Z",
  "mergeRequestUser": "AutumnSaury",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "screeps-arena",
      "kind": "edit",
      "files": [
        {
          "path": "types/screeps-arena/arena/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/arena/prototypes/body-part.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/arena/prototypes/flag.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/arena/prototypes/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/arena/season_alpha/capture_the_flag/advanced.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/arena/season_alpha/capture_the_flag/advanced/prototypes/body-part.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/arena/season_alpha/capture_the_flag/advanced/prototypes/flag.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/arena/season_alpha/capture_the_flag/basic.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/arena/season_alpha/capture_the_flag/basic/prototypes/body-part.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/arena/season_alpha/capture_the_flag/basic/prototypes/flag.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/arena/season_alpha/capture_the_flag/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/arena/season_alpha/collect_and_control/advanced.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/arena/season_alpha/collect_and_control/advanced/constants.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/arena/season_alpha/collect_and_control/advanced/prototypes/area-effect.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/arena/season_alpha/collect_and_control/advanced/prototypes/score-collector.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/arena/season_alpha/collect_and_control/basic.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/arena/season_alpha/collect_and_control/basic/constants.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/arena/season_alpha/collect_and_control/basic/prototypes/area-effect.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/arena/season_alpha/collect_and_control/basic/prototypes/score-collector.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/arena/season_alpha/collect_and_control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/arena/season_alpha/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/constants.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/path-finder.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/construction-site.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/container.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/creep.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/extension.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/game-object.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/owned-structure.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/prototypes.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/rampart.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/resource.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/road.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/source.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/spawn.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/store.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/structure-container.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/structure-extension.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/structure-rampart.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/structure-road.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/structure-spawn.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/structure-tower.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/structure-wall.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/structure.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/tower.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/prototypes/wall.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/utils.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/game/visual.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/screeps-arena/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/screeps-arena/test/screeps-arena-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "thmsndk",
        "pyrodogg"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "Anonymous4078",
      "date": "2024-04-29T12:46:15.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2067717871,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @thmsndk @pyrodogg — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Apr 20, 2024
@AutumnSaury AutumnSaury changed the title [@types/screeps-arena]update to games typing version v1.0.6 (for v0.1.18 game) [@types/screeps-arena]update to game's current typing lib version v1.0.6 (for v0.1.18 game) Apr 20, 2024
@DangerBotOSS
Copy link

Formatting

The following files are not formatted:

  1. types/screeps-arena/package.json
  2. types/screeps-arena/game/visual.d.ts
  3. types/screeps-arena/game/constants.d.ts
  4. types/screeps-arena/game/index.d.ts
  5. types/screeps-arena/game/path-finder.d.ts
as well as these 26 other files...

types/screeps-arena/game/utils.d.ts, types/screeps-arena/arena/index.d.ts, types/screeps-arena/game/prototypes/owned-structure.d.ts, types/screeps-arena/game/prototypes/tower.d.ts, types/screeps-arena/test/screeps-arena-tests.ts, types/screeps-arena/game/prototypes/structure.d.ts, types/screeps-arena/game/prototypes/game-object.d.ts, types/screeps-arena/game/prototypes/spawn.d.ts, types/screeps-arena/game/prototypes/index.d.ts, types/screeps-arena/arena/season_alpha/index.d.ts, types/screeps-arena/arena/season_alpha/collect_and_control/advanced.d.ts, types/screeps-arena/arena/season_alpha/collect_and_control/basic.d.ts, types/screeps-arena/arena/season_alpha/capture_the_flag/advanced.d.ts, types/screeps-arena/arena/season_alpha/capture_the_flag/index.d.ts, types/screeps-arena/arena/season_alpha/capture_the_flag/basic.d.ts, types/screeps-arena/arena/season_alpha/collect_and_control/advanced/constants.d.ts, types/screeps-arena/arena/season_alpha/collect_and_control/basic/constants.d.ts, types/screeps-arena/game/prototypes/creep.d.ts, types/screeps-arena/arena/season_alpha/collect_and_control/advanced/prototypes/score-collector.d.ts, types/screeps-arena/arena/season_alpha/collect_and_control/advanced/prototypes/area-effect.d.ts, types/screeps-arena/arena/season_alpha/collect_and_control/basic/prototypes/score-collector.d.ts, types/screeps-arena/arena/season_alpha/capture_the_flag/advanced/prototypes/flag.d.ts, types/screeps-arena/arena/season_alpha/collect_and_control/basic/prototypes/area-effect.d.ts, types/screeps-arena/arena/season_alpha/capture_the_flag/basic/prototypes/flag.d.ts, types/screeps-arena/arena/season_alpha/capture_the_flag/advanced/prototypes/body-part.d.ts, types/screeps-arena/arena/season_alpha/capture_the_flag/basic/prototypes/body-part.d.ts

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against dc0d53c

@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner labels Apr 29, 2024
@typescript-bot
Copy link
Contributor

@AutumnSaury: Everything looks good here. I am ready to merge this PR (at dc0d53c) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@thmsndk, @pyrodogg: you can do this too.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board Apr 29, 2024
@AutumnSaury
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Apr 29, 2024
@typescript-bot typescript-bot merged commit 86759ed into DefinitelyTyped:master Apr 29, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants