Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[office-js][office-js-preview] (Outlook) Document internet headers API support in Outlook on mobile devices #69444

Conversation

samantharamon
Copy link
Contributor

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 30, 2024

@samantharamon Thank you for submitting this PR!

This is a live comment which I will keep updated.

2 packages in this PR

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69444,
  "author": "samantharamon",
  "headCommitOid": "48615bd298dd1280dc66b7eb3b58c7ba1819e51b",
  "mergeBaseOid": "336514bf08407af44d188b44a55194d029a888cb",
  "lastPushDate": "2024-04-25T21:55:52.000Z",
  "lastActivityDate": "2024-04-30T19:06:09.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "office-js-preview",
      "kind": "edit",
      "files": [
        {
          "path": "types/office-js-preview/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "OfficeDev",
        "Rick-Kirkham",
        "AlexJerabek",
        "ElizabethSamuel-MSFT",
        "alison-mk",
        "samantharamon"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "office-js",
      "kind": "edit",
      "files": [
        {
          "path": "types/office-js/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "OfficeDev",
        "Rick-Kirkham",
        "AlexJerabek",
        "ElizabethSamuel-MSFT",
        "alison-mk",
        "samantharamon"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "ElizabethSamuel-MSFT",
      "date": "2024-04-30T19:06:09.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2086640826,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Edits multiple packages Author is Owner The author of this PR is a listed owner of the package. Untested Change This PR does not touch tests labels Apr 30, 2024
@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Review in New Pull Request Status Board Apr 30, 2024
@typescript-bot
Copy link
Contributor

🔔 @OfficeDev @Rick-Kirkham @AlexJerabek @ElizabethSamuel-MSFT @alison-mk — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Apr 30, 2024
@ElizabethSamuel-MSFT ElizabethSamuel-MSFT merged commit 4354a10 into DefinitelyTyped:master Apr 30, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board Apr 30, 2024
@samantharamon samantharamon deleted the office-js-internet-headers-mobile branch April 30, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Edits multiple packages Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants