New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cytoscape: add pie background style properties #69445
base: master
Are you sure you want to change the base?
Cytoscape: add pie background style properties #69445
Conversation
There are style properties for up to 16 pie chart segments, the documentation lists them as pie-i-background-{color,size,opacity} but for typing the full set must be listed explicitly. Otherwise, type checking accepts the non-existent property pie-i-background-color but rejects the pie-1-background-color.
@cneumann Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69445,
"author": "cneumann",
"headCommitOid": "3cd84328f2051796d534fedb6f45b24d414b48e3",
"mergeBaseOid": "336514bf08407af44d188b44a55194d029a888cb",
"lastPushDate": "2024-04-25T22:11:16.000Z",
"lastActivityDate": "2024-05-15T21:46:49.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "cytoscape",
"kind": "edit",
"files": [
{
"path": "types/cytoscape/cytoscape-tests.ts",
"kind": "test"
},
{
"path": "types/cytoscape/index.d.ts",
"kind": "definition"
}
],
"owners": [
"phreed",
"wy193777",
"ypconstante",
"janniclas",
"gsbelarus",
"peterjferrarotto",
"spaxe",
"Veckodag",
"jsve",
"rogerdubbs"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "sandersn",
"date": "2024-05-15T21:46:49.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2078257898,
"ciResult": "pass"
} |
🔔 @phreed @wy193777 @ypconstante @janniclas @gsbelarus @PeterJFerrarotto @Spaxe @Veckodag @jsve @rogerdubbs — please review this PR in the next few days. Be sure to explicitly select |
@cneumann The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
Re-ping @phreed, @wy193777, @ypconstante, @janniclas, @gsbelarus, @PeterJFerrarotto, @Spaxe, @Veckodag, @jsve, @rogerdubbs: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @cneumann. (Ping @phreed, @wy193777, @ypconstante, @janniclas, @gsbelarus, @PeterJFerrarotto, @Spaxe, @Veckodag, @jsve, @rogerdubbs.) |
@cneumann: Everything looks good here. I am ready to merge this PR (at 3cd8432) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@phreed, @wy193777, @ypconstante, @janniclas, @gsbelarus, @PeterJFerrarotto, @Spaxe, @Veckodag, @jsve, @rogerdubbs: you can do this too.) |
Please fill in this template.
pnpm test <package to test>
.package.json
.