Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-syntax-highlighter] add missing definition in for prism style #69448

Merged
merged 2 commits into from May 3, 2024

Conversation

0753Ljuc
Copy link
Contributor

@0753Ljuc 0753Ljuc commented Apr 26, 2024

  1. prism styles are updated, avilable stylesheet props reference: AVAILABLE_STYLES_PRISM
  2. add relevant test.

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 26, 2024

@0753Ljuc Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69448,
  "author": "0753Ljuc",
  "headCommitOid": "488f7d52e4fc02c1fa4fb9ec53cb719a231bc115",
  "mergeBaseOid": "15c1836f89521ddd11574ef04793c1675de86a9d",
  "lastPushDate": "2024-04-26T08:57:56.000Z",
  "lastActivityDate": "2024-05-03T02:55:00.000Z",
  "mergeOfferDate": "2024-05-02T15:08:51.000Z",
  "mergeRequestDate": "2024-05-03T02:55:00.000Z",
  "mergeRequestUser": "0753Ljuc",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "react-syntax-highlighter",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-syntax-highlighter/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-syntax-highlighter/react-syntax-highlighter-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "NoHomey",
        "guoyunhe",
        "anirban09",
        "michaelyuen",
        "DoK6n"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2024-05-02T15:08:10.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2078949884,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @NoHomey @guoyunhe @anirban09 @michaelyuen @DoK6n — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Apr 26, 2024
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Apr 26, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Apr 26, 2024
@typescript-bot
Copy link
Contributor

@0753Ljuc The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Apr 26, 2024
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Apr 26, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Apr 26, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Apr 26, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Apr 26, 2024
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels May 2, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board May 2, 2024
@typescript-bot
Copy link
Contributor

@0753Ljuc: Everything looks good here. I am ready to merge this PR (at 488f7d5) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@NoHomey, @guoyunhe, @anirban09, @michaelyuen, @DoK6n: you can do this too.)

@0753Ljuc
Copy link
Contributor Author

0753Ljuc commented May 3, 2024

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board May 3, 2024
@typescript-bot typescript-bot merged commit 01e6938 into DefinitelyTyped:master May 3, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants