[@types/passport-oauth2] Allow login rejects and unknown errors

[chdanielmueller]

Added the possiblity to reject logins (user=false) and pass unknown errors

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run pnpm test <package to test>.
• Provide a URL to documentation or source code which provides context for the suggested changes: Documentation within passport-oauth2
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

[typescript-bot]

@chdanielmueller Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• passport-oauth2 — on npm, on unpkg
  • owner-approval: @EduardoAC

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 69451,
  "author": "chdanielmueller",
  "headCommitOid": "61f67fc31d4415176a26a2e356648a223eec5ee3",
  "mergeBaseOid": "15c1836f89521ddd11574ef04793c1675de86a9d",
  "lastPushDate": "2024-04-26T13:21:18.000Z",
  "lastActivityDate": "2024-05-08T05:30:16.000Z",
  "mergeOfferDate": "2024-05-07T18:55:25.000Z",
  "mergeRequestDate": "2024-05-08T05:30:16.000Z",
  "mergeRequestUser": "chdanielmueller",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "passport-oauth2",
      "kind": "edit",
      "files": [
        {
          "path": "types/passport-oauth2/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/passport-oauth2/passport-oauth2-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "pasieronen",
        "WangZishi",
        "EduardoAC",
        "ivan94",
        "daphnesmit",
        "JoelKlint"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "EduardoAC",
      "date": "2024-05-07T18:54:46.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "kurmeroli",
      "date": "2024-04-30T09:48:53.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2079387994,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @pasieronen @wangzishi @EduardoAC @ivan94 @daphnesmit @joelklint — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

Re-ping @pasieronen, @wangzishi, @EduardoAC, @ivan94, @daphnesmit, @joelklint:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[EduardoAC]

LGTM

[typescript-bot]

@chdanielmueller: Everything looks good here. I am ready to merge this PR (at 61f67fc) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@pasieronen, @wangzishi, @EduardoAC, @ivan94, @daphnesmit, @joelklint: you can do this too.)

[chdanielmueller]

Ready to merge