-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Beacon transport type #69481
Add Beacon transport type #69481
Conversation
This is very poorly documented so it has been missed.
@tomasdev Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. InactiveThis PR has been inactive for 14 days — please merge or say something if there's a problem, otherwise it will be closed! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69481,
"author": "tomasdev",
"headCommitOid": "d421dc261c04db8a94201162c7dd2d9d8e1675a1",
"mergeBaseOid": "4354a1088a2881bf6613b98c84d18e614f08705e",
"lastPushDate": "2024-04-30T19:25:37.000Z",
"lastActivityDate": "2024-05-26T19:23:10.000Z",
"mergeOfferDate": "2024-05-16T17:12:41.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "gtag.js",
"kind": "edit",
"files": [
{
"path": "types/gtag.js/index.d.ts",
"kind": "definition"
}
],
"owners": [
"rokt33r",
"KsAkira10"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "sandersn",
"date": "2024-05-16T17:12:03.000Z",
"isMaintainer": true
},
{
"type": "stale",
"reviewer": "jakebailey",
"date": "2024-05-06T19:25:34.000Z",
"abbrOid": "07483c7"
}
],
"mainBotCommentID": 2086789276,
"ciResult": "pass"
} |
🔔 @Rokt33r @KsAkira10 — please review this PR in the next few days. Be sure to explicitly select |
The link you have in the PR goes to an error page, so this can't really be confirmed. |
Must have been a temporary problem, weird. |
Re-ping @Rokt33r, @KsAkira10: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes so the bot knows the current status.
@tomasdev One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
Done! |
@sandersn, @jakebailey Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
@jakebailey Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
Re-ping @tomasdev / @Rokt33r, @KsAkira10: This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Jun 15th (in three weeks) if this doesn't happen. (If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.) |
LGTM! |
This is very poorly documented so it has been missed.
Please fill in this template.
pnpm test <package to test>
.Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.If changing an existing definition:
package.json
.If removing a declaration:
notNeededPackages.json
.