[@types/fs-readdir-recursive] Complete typings

[JLHwung]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run pnpm test <package to test>.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/fs-utils/fs-readdir-recursive/blob/f810b44477696081ebef9c0d5eafb24005c8e82b/index.js#L6

The previous definition was missing the third and the fourth parameter. Spot this issue when I am working on a Babel PR https://github.com/babel/babel/pull/16459/files#r1586574307

[typescript-bot]

@JLHwung Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• fs-readdir-recursive — on npm, on unpkg
  • owner-approval: @pscanf

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 69489,
  "author": "JLHwung",
  "headCommitOid": "cbb0029345ecfe350ed7a77bb9f40c95273ad533",
  "mergeBaseOid": "5ffffd80f639d121df1903bf2a13a62f01cac640",
  "lastPushDate": "2024-05-01T18:40:23.000Z",
  "lastActivityDate": "2024-05-01T19:27:32.000Z",
  "mergeOfferDate": "2024-05-01T19:25:36.000Z",
  "mergeRequestDate": "2024-05-01T19:27:32.000Z",
  "mergeRequestUser": "pscanf",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "fs-readdir-recursive",
      "kind": "edit",
      "files": [
        {
          "path": "types/fs-readdir-recursive/fs-readdir-recursive-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/fs-readdir-recursive/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "pscanf"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "pscanf",
      "date": "2024-05-01T19:24:57.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2088904126,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @pscanf — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@JLHwung: Everything looks good here. I am ready to merge this PR (at cbb0029) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@pscanf: you can do this too.)

[pscanf]

Ready to merge.