[@types/node] Add missing optional parameters to EventEmitter.on

types/node/events.d.ts

@@ -76,8 +76,32 @@ declare module "events" {
         captureRejections?: boolean | undefined;
     }
     interface StaticEventEmitterOptions {
+        /**
+         * Can be used to cancel awaiting events.
+         */
         signal?: AbortSignal | undefined;
     }
+    interface StaticEventEmitterOnOptions extends StaticEventEmitterOptions {
+        /**
+         * Names of events that will end the iteration.
+         * @since v20.0.0
+         */
+        close?: readonly string[] | undefined;
+        /**
+         * The high watermark. The emitter is paused every time the size of events being buffered is higher than it.
+         * Supported only on emitters implementing `pause()` and `resume()` methods.
+         * @default Number.MAX_SAFE_INTEGER
+         * @since v20.0.0
+         */
+        highWatermark?: number | undefined;
+        /**
+         * The low watermark. The emitter is resumed every time the size of events being buffered is lower than it.
+         * Supported only on emitters implementing `pause()` and `resume()` methods.
+         * @default 1
+         * @since v20.0.0
+         */
+        lowWatermark?: number | undefined;
+    }
     interface EventEmitter<T extends EventMap<T> = DefaultEventMap> extends NodeJS.EventEmitter<T> {}
     type EventMap<T> = Record<keyof T, any[]> | DefaultEventMap;
     type DefaultEventMap = [never];
@@ -260,8 +284,8 @@ declare module "events" {
          */
         static on(
             emitter: NodeJS.EventEmitter,
-            eventName: string,
-            options?: StaticEventEmitterOptions,
+            eventName: string | symbol,
+            options?: StaticEventEmitterOnOptions,
         ): AsyncIterableIterator<any>;
         /**
          * A class method that returns the number of listeners for the given `eventName` registered on the given `emitter`.

types/node/test/events.ts

@@ -3,6 +3,7 @@ import * as events from "node:events";
 const emitter: events = new events.EventEmitter();
 declare const listener: (...args: any[]) => void;
 declare const event: string | symbol;
+declare const abortSignal: AbortSignal;
 declare const any: any;
 
 {
@@ -39,10 +40,21 @@ declare const any: any;
     let result: Promise<number[]>;
 
     result = events.once(emitter, event);
+    result = events.once(emitter, event, { signal: abortSignal });
 
     emitter.emit(event, 42);
 }
 
+{
+    let result: AsyncIterableIterator<any>;
+
+    result = events.on(emitter, event);
+    result = events.on(emitter, event, { signal: abortSignal });
+    result = events.on(emitter, event, { close: ["close"] });
+    result = events.on(emitter, event, { highWatermark: 42 });
+    result = events.on(emitter, event, { lowWatermark: 42 });
+}
+
 {
     let result: Function[];