-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@types/yandex-maps] add coordSystem
namespace, add `GeoQueryResult…
#69544
Conversation
@Armanio Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69544,
"author": "Armanio",
"headCommitOid": "c90ad4dd934d5b1089e616e08d0b0c0c8ea24b86",
"mergeBaseOid": "64828b61751341bfdb2bd5ba88ef61c1f1f77cb8",
"lastPushDate": "2024-05-07T11:51:25.000Z",
"lastActivityDate": "2024-05-19T20:17:35.000Z",
"mergeOfferDate": "2024-05-19T20:16:09.000Z",
"mergeRequestDate": "2024-05-19T20:17:35.000Z",
"mergeRequestUser": "Armanio",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "yandex-maps",
"kind": "edit",
"files": [
{
"path": "types/yandex-maps/index.d.ts",
"kind": "definition"
}
],
"owners": [
"Delagen",
"gastwork13",
"kaskar2008"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2024-05-19T20:15:32.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "Delagen",
"date": "2024-05-18T16:36:00.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 2098224422,
"ciResult": "pass"
} |
Hey @Armanio, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
🔔 @Delagen @gastwork13 @kaskar2008 — please review this PR in the next few days. Be sure to explicitly select |
@Armanio The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
…` class and add `geoQuery` static func
Re-ping @gastwork13, @kaskar2008: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
Strange class IPromiseProvider has constructor, but looks like interface IThenable |
⏳ Hi @Armanio, It's been a few days since this PR was approved by Delagen and we're waiting for a DT maintainer to give a review. If you would like to short-circuit this wait, you can edit some of the test files in the package which verify how the |
necesito aprender a utilizar esto.quien me enseña
El sáb, 18 may 2024 a las 12:05, Sergey Vohmyanin ***@***.***>)
escribió:
… Strange class IPromiseProvider has constructor, but looks like interface
IThenable
—
Reply to this email directly, view it on GitHub
<#69544 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIHFL5ASL4MCDWZS457BLSDZC534PAVCNFSM6AAAAABHK2X4C6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYHA3DONBRHA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
All OK. That's looks like described in Yandex API |
@Armanio: Everything looks good here. I am ready to merge this PR (at c90ad4d) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@Delagen, @gastwork13, @kaskar2008: you can do this too.) |
Ready to merge |
…
class and add
geoQuery` static funcPlease fill in this template.
pnpm test <package to test>
.Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.If changing an existing definition:
package.json
.If removing a declaration:
notNeededPackages.json
.