Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update imagemin's Plugin to Uint8Array instead of Buffer. #69661

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

jaccarmac
Copy link
Contributor

@jaccarmac jaccarmac commented May 22, 2024

I noticed failures in web-scrobbler/web-scrobbler#4717. imagemin-pngquant@10 contains imagemin/imagemin-pngquant@981b216#diff-7aa4473ede4abd9ec099e87fec67fd57afafaf39e05d493ab4533acc38547eb8L58-R51, which replaces Buffer with Uint8Array, causing a type mismatch. imagemin@9 contains a similar change imagemin/imagemin@0f2a0aa#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R68, though that package's types are here and said change is less documented.

Please fill in this template.

If changing an existing definition:

I noticed failures in web-scrobbler/web-scrobbler#4717. imagemin-pngquant@10 contains
imagemin/imagemin-pngquant@981b216#diff-7aa4473ede4abd9ec099e87fec67fd57afafaf39e05d493ab4533acc38547eb8L58-R51,
which replaces Buffer with Uint8Array, causing a type mismatch. imagemin@9 contains a similar change
imagemin/imagemin@0f2a0aa#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R68,
though that package's types are here and said change is less documented.
@typescript-bot
Copy link
Contributor

typescript-bot commented May 22, 2024

@jaccarmac Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69661,
  "author": "jaccarmac",
  "headCommitOid": "b4162432834bf4cef7192369b0dbf0d7c75a9358",
  "mergeBaseOid": "f6d4d15522356eba4a0267142834e3abc6b603fc",
  "lastPushDate": "2024-05-22T17:54:37.000Z",
  "lastActivityDate": "2024-06-03T20:45:14.000Z",
  "maintainerBlessed": "Waiting for Code Reviews",
  "mergeOfferDate": "2024-06-03T09:22:38.000Z",
  "mergeRequestDate": "2024-06-03T20:45:14.000Z",
  "mergeRequestUser": "jaccarmac",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "imagemin",
      "kind": "edit",
      "files": [
        {
          "path": "types/imagemin/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/imagemin/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "romain-faust",
        "hkjeffchan"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "hkjeffchan",
      "date": "2024-06-03T09:22:00.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2125427380,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels May 22, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 22, 2024
@typescript-bot
Copy link
Contributor

Hey @jaccarmac,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Contributor

🔔 @romain-faust @hkjeffchan — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 22, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board May 22, 2024
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label May 22, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board May 22, 2024
@typescript-bot
Copy link
Contributor

@jaccarmac The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label May 22, 2024
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board May 22, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 22, 2024
@sheetalkamat sheetalkamat moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board May 28, 2024
@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Jun 2, 2024
@typescript-bot
Copy link
Contributor

Re-ping @romain-faust, @hkjeffchan:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Jun 3, 2024
@typescript-bot
Copy link
Contributor

@jaccarmac: Everything looks good here. I am ready to merge this PR (at b416243) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@romain-faust, @hkjeffchan: you can do this too.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board Jun 3, 2024
@jaccarmac
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Jun 3, 2024
@typescript-bot typescript-bot merged commit d4fd396 into DefinitelyTyped:master Jun 3, 2024
4 checks passed
jaccarmac added a commit to web-scrobbler/web-scrobbler that referenced this pull request Jun 3, 2024
jaccarmac added a commit to web-scrobbler/web-scrobbler that referenced this pull request Jun 3, 2024
* Bump imagemin-pngquant from 9.0.2 to 10.0.0

Bumps [imagemin-pngquant](https://github.com/imagemin/imagemin-pngquant) from 9.0.2 to 10.0.0.
- [Release notes](https://github.com/imagemin/imagemin-pngquant/releases)
- [Commits](imagemin/imagemin-pngquant@v9.0.2...v10.0.0)

---
updated-dependencies:
- dependency-name: imagemin-pngquant
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump @types/imagemin from 8.0.5 to 9.0.0.

Unblocks #4717 via DefinitelyTyped/DefinitelyTyped#69661.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants