Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mastercard-client-encryption] Add package mastercard-client-encryption #69666

Merged

Conversation

eLoyyyyy
Copy link
Contributor

@eLoyyyyy eLoyyyyy commented May 23, 2024

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@typescript-bot
Copy link
Contributor

typescript-bot commented May 23, 2024

@eLoyyyyy Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes when there are new packages added

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69666,
  "author": "eLoyyyyy",
  "headCommitOid": "a27150fbca437f8b165a71e56670352a485478f1",
  "mergeBaseOid": "bf361d25f8e9e2b40b37eeb4cbcc042b9d791fcd",
  "lastPushDate": "2024-05-23T03:08:37.000Z",
  "lastActivityDate": "2024-05-23T03:08:37.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "mastercard-client-encryption",
      "kind": "add",
      "files": [
        {
          "path": "types/mastercard-client-encryption/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/mastercard-client-encryption/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/mastercard-client-encryption/mastercard-client-encryption-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/mastercard-client-encryption/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/mastercard-client-encryption/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "eLoyyyyy"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 2126149939,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the New Definition This PR creates a new definition package. label May 23, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in Old Pull Request Status Board May 23, 2024
@typescript-bot
Copy link
Contributor

🔔 @eLoyyyyy — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in Old Pull Request Status Board May 23, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Code Reviews in Old Pull Request Status Board May 23, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in Old Pull Request Status Board May 23, 2024
@weswigham weswigham merged commit d7ecc5a into DefinitelyTyped:master May 23, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Needs Maintainer Action in Old Pull Request Status Board May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Definition This PR creates a new definition package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants