Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create new typescript definitions file for xixixao/noisejs #8291

Merged
merged 1 commit into from Feb 29, 2016

Conversation

izmhr
Copy link
Contributor

@izmhr izmhr commented Feb 27, 2016

case 1. Add a new type definition.

  • checked compilation succeeds with --target es6 and --noImplicitAny options.
  • has correct naming convention
  • has a test file with the suffix of -tests.ts or -tests.tsx.

@dt-bot
Copy link
Member

dt-bot commented Feb 27, 2016

noisejs/noisejs.d.ts

Checklist

horiuchi added a commit that referenced this pull request Feb 29, 2016
create new typescript definitions file for xixixao/noisejs
@horiuchi horiuchi merged commit 62c4bf2 into DefinitelyTyped:master Feb 29, 2016
@horiuchi
Copy link
Member

@izmhr Thanks mate!

@izmhr
Copy link
Contributor Author

izmhr commented Feb 29, 2016

It's my pleasure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants