create new typescript definitions file for xixixao/noisejs #8291

Merged
merged 1 commit into from Feb 29, 2016

Conversation

Projects
None yet
3 participants
@izmhr
Contributor

izmhr commented Feb 27, 2016

case 1. Add a new type definition.

  • checked compilation succeeds with --target es6 and --noImplicitAny options.
  • has correct naming convention
  • has a test file with the suffix of -tests.ts or -tests.tsx.
@dt-bot

This comment has been minimized.

Show comment
Hide comment
@dt-bot

dt-bot Feb 27, 2016

Member

noisejs/noisejs.d.ts

Checklist

Member

dt-bot commented Feb 27, 2016

noisejs/noisejs.d.ts

Checklist

horiuchi added a commit that referenced this pull request Feb 29, 2016

Merge pull request #8291 from izmhr/master
create new typescript definitions file for xixixao/noisejs

@horiuchi horiuchi merged commit 62c4bf2 into DefinitelyTyped:master Feb 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@horiuchi

This comment has been minimized.

Show comment
Hide comment
@horiuchi

horiuchi Feb 29, 2016

Member

@izmhr Thanks mate!

Member

horiuchi commented Feb 29, 2016

@izmhr Thanks mate!

@izmhr

This comment has been minimized.

Show comment
Hide comment
@izmhr

izmhr Feb 29, 2016

Contributor

It's my pleasure.

Contributor

izmhr commented Feb 29, 2016

It's my pleasure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment