IModalServiceInstance missing closed promise

[ritter]

Improvement to existing type definition.

• documentation or source code reference which provides context for the suggested changes.
  url: https://github.com/angular-ui/bootstrap/tree/master/src/modal/docs

added missing closed promise to IModalServiceInstance

[dt-bot]

angular-ui-bootstrap/angular-ui-bootstrap.d.ts

to author (@xt0rted). Could you review this PR?
👍 or 👎?

Checklist

• pass the Travis CI test?

[xt0rted]

There should be a reference to this in the tests. I'm also not sure why there's a merge.

[ritter]

There is a merge simply because I merged it to my fork first.
As for the test, I'm not sure what you want me to do, if anything is needed.

On Fri, Apr 22, 2016 at 11:49 AM, Brian Surowiec notifications@github.com
wrote:

There should be a reference to this in the tests. I'm also not sure why
there's a merge.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#9083 (comment)

[xt0rted]

There's implementations of most of the features in the test file just to ensure the definition is setup correctly. The opened promise can be seen here angular-ui-bootstrap-tests.ts#L176

[ritter]

I've committed the changes to add the test for the closed promise, let me
know if you need anything else.

Thanks much.

Regards,

On Sat, Apr 23, 2016 at 4:02 PM, Brian Surowiec notifications@github.com
wrote:

There's implementations of most of the features in the test file just to
ensure the definition is setup correctly. The opened promise can be seen
here angular-ui-bootstrap-tests.ts#L176

DefinitelyTyped/angular-ui-bootstrap/angular-ui-bootstrap-tests.ts

Line 176 in 2d448c0

modalInstance.opened.then(()=> {

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#9083 (comment)

[xt0rted]

looks good to me 👍