New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New type definition for d3Kit v1.1.0 #9680

Merged

vvakame merged 1 commit into DefinitelyTyped:master from morphatic:master

Jun 19, 2016

Contributor

morphatic commented Jun 16, 2016 •

edited

case 1. Add a new type definition.

checked compilation succeeds with --target es6 and --noImplicitAny options.
has correct naming convention
has a test file with the suffix of -tests.ts or -tests.tsx.

Note, this is the first time I've ever submitted a type definition. Would be happy to receive criticism/feedback on how I did.

cc: @kristw, @trebor (primary contributors to https://github.com/twitter/d3kit)


          added all tests

9cb662f

Member

dt-bot commented Jun 16, 2016 •

edited by vvakame

d3kit/d3kit.d.ts

Checklist

is correct naming convention?
has a test file? (d3kit/d3kit-tests.ts or d3kit/d3kit-tests.tsx)
pass the Travis CI test?

morphatic mentioned this pull request

Added typescript type definition for d3Kit to DefinitelyTyped twitter/d3kit#15

Closed

vvakame merged commit 9646a7d into DefinitelyTyped:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment