[UnderScore] Update definitions of findIndex/findLastIndex #9711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
underscore/underscore.d.ts to authors (@borisyankov @jbaldwin @ccurrens). Could you review this PR? Checklist
|
nallwhy
changed the title
|
As there are many other methods that transform their predicates through |
| @@ -1017,6 +1002,11 @@ interface UnderscoreStatic { | |||
| predicate: _.ListIterator<T, boolean>, | |||
| context?: any): number; | |||
|
|
|||
| findIndex<T, U extends {}>( | |||
There was a problem hiding this comment.
U extends {} means the same thing as just U. it is rather confusing to use this for some declarations and not others. so i would recommend removing it.
mhegazy
added
the
Revision needed
nallwhy
force-pushed
the
underscore-find_index
branch
from
e1f8f28
to
464602f
Compare
|
@mhegazy I fixed it. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As predicates of
findIndex/findLastIndexare transformed by_.iteratee, they can take Object as a predicates.And
findIndex/findLastIndexcan't return __Chain. I changed it to __ChainSingle.http://underscorejs.org/#iteratee
http://underscorejs.org/#findIndex