This repository has been archived by the owner on Apr 30, 2019. It is now read-only.
Eliminate implicit property ordering for cache key #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an implicit ordering of setting properties and the invocation of base class methods in order for GithubLoader to properly initialize itself with the appropriate cache key. This change removes that implicit ordering and passes, explicitly, the cache key string value to the `GithubLoader::_initGithubLoader` method.
|
The build failure by AppVeyor and Travis CI is reporting exists already on the |
|
@ericvw I'm solving this test. This is not with your implementation. |
|
merged! |
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an implicit ordering of setting properties and the invocation
of base class methods in order for GithubLoader to properly initialize
itself with the appropriate cache key. This change removes that
implicit ordering and passes, explicitly, the cache key string value to
the
GithubLoader::_initGithubLoadermethod.Note that I am working towards taking care of #186, but in order to do so, I need to make some incremental changes along the way.