New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python executable cleanups #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add documentation change also to state that we now only support python3
@@ -7,6 +7,8 @@ | |||
|
|||
""" | |||
|
|||
import sys | |||
|
|||
__version__ = "2023.02.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we waiting for the output change to create a new release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have always only supported python>=3.8 as stated on https://cotainr.readthedocs.io/en/latest/user_guide/index.html#cotainr-dependencies. The only change is that we now explicitly call |
This is a follow-up to #30 to fully implement PEP394 in cotainr.
python3
executable instead ofpython
.sys.executable
when applicable