Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use button component on call to action #1

Merged
merged 4 commits into from
Jan 4, 2018
Merged

Use button component on call to action #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f45e079
Use button component on call to action link
Jan 4, 2018
ee038f2
Add `call to action` classname filter to available filters
Jan 4, 2018
cb6c448
Add `<div />` around CTA button
Jan 4, 2018
a73a6c9
Update required core version
Jan 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ Install the module using Composer `composer require dekodeinteraktiv/hogan-banne
…

## Available filters
- TODO
- `hogan/module/banner/cta_css_classes` Call to action button classnames.
12 changes: 9 additions & 3 deletions assets/template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
* $this is an instance of the Banner object.
*
* Available properties:
* $this->heading (string) Module heading.
* TODO:
* $this->call_to_action (array|null) Call to action link.
* $this->heading (string) Module heading.
*
* @package Hogan
*/
Expand Down Expand Up @@ -38,7 +38,13 @@
<?php echo $this->content; ?>
<?php endif; ?>

<?php echo $this->cta_link; ?>
<?php
if ( ! empty( $this->call_to_action ) ) {
echo '<div>';
hogan_component( 'button', $this->call_to_action );
echo '</div>';
}
?>
</div>

<?php if ( 'large' === $this->image_size && ! empty( $this->image_src ) ) : ?>
Expand Down
26 changes: 10 additions & 16 deletions class-banner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,11 @@ class Banner extends Module {
public $image_src;

/**
* Rendered call to action link.
* Call to action link.
*
* @var $cta_link
* @var array|null $call_to_action
*/
public $cta_link;
public $call_to_action = null;

/**************/
/***SETTINGS***/
Expand Down Expand Up @@ -354,20 +354,14 @@ public function load_args_from_layout_content( array $raw_content, int $counter
$image_args = wp_parse_args( apply_filters( 'hogan/module/banner/image/args', [] ), $default_image_args );
$this->image_content = wp_get_attachment_image( $raw_content['image_id'], $image_args['size'], $image_args['icon'], $image_args['attr'] );

// Call to action button.
if ( ! empty( $raw_content['cta'] ) ) {
$cta = $raw_content['cta'];
$cta['title'] = $cta['title'] ?: __( 'Read more', 'hogan-banner' );
$cta['classname'] = apply_filters( 'hogan/module/banner/cta_css_classes', '', $this );

if ( ! empty( $raw_content['cta'] ) ) :
$cta = $raw_content['cta'];
$cta_classes_array = apply_filters( 'hogan/module/banner/cta_css_classes', [ 'button' ], $this );
$cta_classes_escaped = array_map( 'esc_attr', $cta_classes_array );
$this->cta_link = sprintf( '<div><a href="%1$s"%2$s%3$s>%4$s</a></div>',
$cta['url'] ?: '#',
'' === $cta['target'] ? '' : ' target="' . $cta['target'] . '"',
! empty( $cta_classes_escaped ) ? 'class="' . trim( implode( ' ', array_filter( $cta_classes_escaped ) ) ) . '"' : '',
$cta['title'] ?: esc_html__( 'Read more', 'hogan-banner' )
);
else :
$this->cta_link = '';
endif;
$this->call_to_action = $cta;
}

parent::load_args_from_layout_content( $raw_content, $counter );

Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"require": {
"php": ">=5.5",
"composer/installers": "~1.2",
"dekodeinteraktiv/hogan-core": "^1.0"
"dekodeinteraktiv/hogan-core": "^1.0.10"
},
"archive": {
"exclude": [
Expand Down