Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated: Make compatible with Dekode Starter Theme #466

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

pdewouters
Copy link
Contributor

@pdewouters pdewouters commented Aug 22, 2023

  • Replaces dekode-theme with dekode-starter-theme
  • Modifies the webpack config so that developers can use a block library plugin for all custom blocks (taken from an existing working project)
  • CSS linting does not use SCSS preset anymore
  • Include npm packages from the theme in the main package,json

@pdewouters pdewouters force-pushed the dekode-starter-theme-compat branch 3 times, most recently from 82648f9 to 2a0a133 Compare August 22, 2023 14:47
walbo
walbo previously approved these changes Aug 23, 2023
@stian-overasen
Copy link
Member

Do we want a full out-of-sync copy of the Starter Theme in this repo?

@walbo
Copy link
Collaborator

walbo commented Aug 25, 2023

I was planning on setting up a autosync from the theme repo after this was merged. In the autosync we can remove all unwanted files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just block-library?

@Sisanu
Copy link
Contributor

Sisanu commented Aug 30, 2023

Shouldn't this tooling also include something about external plugins? I know we are using at least one (Gravity Forms) in all the projects.

@pdewouters
Copy link
Contributor Author

@Sisanu can you be more specific? The goal here is to just make project base work with the new starter theme.

@stian-overasen
Copy link
Member

Shouldn't this tooling also include something about external plugins? I know we are using at least one (Gravity Forms) in all the projects.

Adding Gravity Forms as a default plugin to Project Base would be a different PR.

@Sisanu
Copy link
Contributor

Sisanu commented Aug 30, 2023

@Sisanu can you be more specific? The goal here is to just make project base work with the new starter theme.

From my perspective, adding the webpack configs or what else is required related to using external plugins should also be part of the project base. Because that needs to be tested that works properly in a real scenario, with the rest of the packages and assets handling we are using.

@Sisanu
Copy link
Contributor

Sisanu commented Aug 30, 2023

Ah! 🤦🏻‍♀️ @pdewouters @stian-overasen, I was so focused on my discussion with Henning when he gave me the PR link, that I missed the title. You are both right, this is not the right PR for what I asked. Will ask the same question in another context.

This was referenced Dec 18, 2023
@olethomas
Copy link
Member

AXE: https://dekode.no

@stian-overasen stian-overasen marked this pull request as draft June 21, 2024 05:36
@stian-overasen stian-overasen changed the title Make compatible with Dekode Starter Theme Outdated: Make compatible with Dekode Starter Theme Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants