-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outdated: Make compatible with Dekode Starter Theme #466
base: main
Are you sure you want to change the base?
Conversation
82648f9
to
2a0a133
Compare
2a0a133
to
819171c
Compare
Do we want a full out-of-sync copy of the Starter Theme in this repo? |
I was planning on setting up a autosync from the theme repo after this was merged. In the autosync we can remove all unwanted files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about just block-library
?
Shouldn't this tooling also include something about external plugins? I know we are using at least one (Gravity Forms) in all the projects. |
@Sisanu can you be more specific? The goal here is to just make project base work with the new starter theme. |
Adding Gravity Forms as a default plugin to Project Base would be a different PR. |
From my perspective, adding the webpack configs or what else is required related to using external plugins should also be part of the project base. Because that needs to be tested that works properly in a real scenario, with the rest of the packages and assets handling we are using. |
Ah! 🤦🏻♀️ @pdewouters @stian-overasen, I was so focused on my discussion with Henning when he gave me the PR link, that I missed the title. You are both right, this is not the right PR for what I asked. Will ask the same question in another context. |
AXE: https://dekode.no |
dekode-theme
withdekode-starter-theme
package,json