Add bindings for aarch64-linux-android #291
Open
+2,923
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry but I don't want to merge just bindings without CI support. The existing supported bindings all have CI which will update and maintain the bindings as the target and quickjs changes. Bindings without CI will go out of date, requiring maintenance which I often can't and also don't want to do. If you are willing to add CI integration to automatically update the bindings then I am happy to merge it. |
|
It seems not as easy as imagined... |
|
I would suggest looking at cross-rs (https://github.com/cross-rs/cross), it simplifies a lot the setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although you can use the bindgen feature #266 , bindgen_rs fails to compile in some scenarios, adding aarch64-linux-android will make compiling faster and easier.