feat(core, value): add as_bytes_mut() to array buffer and typed array #329
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DelSkayn
requested changes
Jul 4, 2024
Comment on lines
+115
to
118
| pub fn as_bytes_mut(&self) -> Option<&mut [u8]> { | ||
| let raw = Self::get_raw(self.as_value())?; | ||
| Some(unsafe { slice::from_raw_parts_mut(raw.ptr.as_ptr(), raw.len) }) | ||
| } |
There was a problem hiding this comment.
This is unsound. It allows you to call as_bytes_mut twice on the same object resulting in aliasing mutable references which is undefined behavior. This also cannot be avoided by making the function take a mutable reference to self as you can have two separate ArrayBuffer values point to the same slice.
In order to make this sound, there needs to be some kind of RefCell/Mutex like lock to prevent aliasing mutable references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
There's currently not a way to modify the bytes of an
ArrayBufferor a typed array likeUint8Array, so this PR adds newas_bytes_mut()methods that follows the typical convention in Rust.